From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wtzr9-0002n5-BP for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:43:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wtzr4-0002uH-3c for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:43:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wtzr3-0002tp-QO for qemu-devel@nongnu.org; Mon, 09 Jun 2014 09:43:18 -0400 From: Stefan Hajnoczi Date: Mon, 9 Jun 2014 15:43:03 +0200 Message-Id: <1402321386-17773-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1402321386-17773-1-git-send-email-stefanha@redhat.com> References: <1402321386-17773-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 2/5] vmxnet3: fix msix vectors unuse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Jiri Pirko , Stefan Hajnoczi From: Jiri Pirko In vmxnet3_cleanup_msix(), there is called msix_vector_unuse() with VMXNET3_MAX_INTRS. That is not correct since vector of value VMXNET3_MAX_INTRS was never used. Also all the used vectors are not un-used. So call vmxnet3_unuse_msix_vectors() instead which does the correct job. Signed-off-by: Jiri Pirko Acked-by: Dmitry Fleytman Signed-off-by: Stefan Hajnoczi --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 1bb9259..f3be494 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -2050,7 +2050,7 @@ vmxnet3_cleanup_msix(VMXNET3State *s) PCIDevice *d = PCI_DEVICE(s); if (s->msix_used) { - msix_vector_unuse(d, VMXNET3_MAX_INTRS); + vmxnet3_unuse_msix_vectors(s, VMXNET3_MAX_INTRS); msix_uninit(d, &s->msix_bar, &s->msix_bar); } } -- 1.9.3