From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Rick Liu <yrliu.ca@gmail.com>
Subject: [Qemu-devel] [PULL 7/8] configure: duplicate/incorrect order of -lrt
Date: Tue, 10 Jun 2014 07:56:20 +0200 [thread overview]
Message-ID: <1402379781-844-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1402379781-844-1-git-send-email-pbonzini@redhat.com>
From: Rick Liu <yrliu.ca@gmail.com>
'-lrt' flag duplication/incorrect order
would cause 'undefined reference to clock_gettime' error during compilation time.
Before fix:
... -o qemu-bridge-helper qemu-bridge-helper.o -lrt -pthread -lgthread-2.0 -lrt -lglib-2.0
After fix:
... -o qemu-bridge-helper qemu-bridge-helper.o -pthread -lgthread-2.0 -lrt -lglib-2.0
Reference:
http://hi.baidu.com/sanitywolf/item/7a8b69c1e76dd220a0b50ab1
Signed-off-by: Rick Liu <yrliu.ca@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index a994f41..96f91ad 100755
--- a/configure
+++ b/configure
@@ -3452,9 +3452,9 @@ EOF
if compile_prog "" "" ; then
:
# we need pthread for static linking. use previous pthread test result
-elif compile_prog "" "-lrt $pthread_lib" ; then
- LIBS="-lrt $LIBS"
- libs_qga="-lrt $libs_qga"
+elif compile_prog "" "$pthread_lib -lrt" ; then
+ LIBS="$LIBS -lrt"
+ libs_qga="$libs_qga -lrt"
fi
if test "$darwin" != "yes" -a "$mingw32" != "yes" -a "$solaris" != yes -a \
--
1.8.3.1
next prev parent reply other threads:[~2014-06-10 5:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 5:56 [Qemu-devel] [PULL 0/8] build system and libcacard changes for 2014-06-10 Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 1/8] glib-compat.h: add new thread API emulation on top of pre-2.31 API Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu Paolo Bonzini
2014-06-17 17:10 ` Ed Maste
2014-06-17 17:15 ` Paolo Bonzini
2014-06-17 19:11 ` Ed Maste
2014-06-18 9:25 ` Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 3/8] libcacard: replace qemu thread primitives with glib ones Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 4/8] libcacard: actually use symbols file Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 5/8] libcacard: improve documentation Paolo Bonzini
2014-06-10 5:56 ` [Qemu-devel] [PULL 6/8] rules.mak: Rewrite unnest-vars Paolo Bonzini
2014-06-10 10:40 ` Paolo Bonzini
2014-06-10 5:56 ` Paolo Bonzini [this message]
2014-06-10 5:56 ` [Qemu-devel] [PULL 8/8] configure: unset interfering variables Paolo Bonzini
2014-06-10 10:00 ` [Qemu-devel] [PULL 0/8] build system and libcacard changes for 2014-06-10 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402379781-844-8-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yrliu.ca@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).