qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andreas Faerber <afaerber@suse.de>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 3/3] virtio-blk: remove need for explicit x-data-plane=on option
Date: Tue, 10 Jun 2014 09:03:22 +0200	[thread overview]
Message-ID: <1402383802-14252-4-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1402383802-14252-1-git-send-email-stefanha@redhat.com>

The x-data-plane=on|off option is no longer useful because the
iothread=<iothread> option conveys the same information plus which
IOThread to use.

Do not delete x-data-plane=on|off yet as a convenience to people using
this legacy experimental option.  We will drop it in QEMU 2.2.

Instead, turn on data-plane when either x-data-plane=on or
iothread=<iothread> are used.  The following command-line uses
data-plane:

  qemu -device virtio-blk-pci,iothread=foo,drive=drive0

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/block/dataplane/virtio-blk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index c10b7b7..8ac6049 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -334,7 +334,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk,
 
     *dataplane = NULL;
 
-    if (!blk->data_plane) {
+    if (!blk->data_plane && !blk->iothread) {
         return;
     }
 
-- 
1.9.3

  parent reply	other threads:[~2014-06-10  8:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10  7:03 [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property Stefan Hajnoczi
2014-06-10  7:03 ` [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property Stefan Hajnoczi
2014-06-10 18:35   ` Paolo Bonzini
2014-06-18 11:11     ` Stefan Hajnoczi
2014-06-18 13:01       ` Paolo Bonzini
2014-06-10  7:03 ` [Qemu-devel] [PATCH 2/3] qdev: drop iothread property type Stefan Hajnoczi
2014-06-10  7:03 ` Stefan Hajnoczi [this message]
2014-06-10  9:03 ` [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property Paolo Bonzini
2014-06-30 13:09 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402383802-14252-4-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=afaerber@suse.de \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).