From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuHil-0004F1-Ud for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuHie-0006YX-Jg for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:47:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuHie-0006YM-Af for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:47:48 -0400 From: Stefan Hajnoczi Date: Tue, 10 Jun 2014 09:03:22 +0200 Message-Id: <1402383802-14252-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1402383802-14252-1-git-send-email-stefanha@redhat.com> References: <1402383802-14252-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] virtio-blk: remove need for explicit x-data-plane=on option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Andreas Faerber , Stefan Hajnoczi The x-data-plane=on|off option is no longer useful because the iothread= option conveys the same information plus which IOThread to use. Do not delete x-data-plane=on|off yet as a convenience to people using this legacy experimental option. We will drop it in QEMU 2.2. Instead, turn on data-plane when either x-data-plane=on or iothread= are used. The following command-line uses data-plane: qemu -device virtio-blk-pci,iothread=foo,drive=drive0 Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index c10b7b7..8ac6049 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -334,7 +334,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *blk, *dataplane = NULL; - if (!blk->data_plane) { + if (!blk->data_plane && !blk->iothread) { return; } -- 1.9.3