From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuGjc-0001GY-Nt for qemu-devel@nongnu.org; Tue, 10 Jun 2014 03:44:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuGjX-0000f4-UC for qemu-devel@nongnu.org; Tue, 10 Jun 2014 03:44:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuGjX-0000ew-MV for qemu-devel@nongnu.org; Tue, 10 Jun 2014 03:44:39 -0400 Message-ID: <1402386273.8739.14.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 10 Jun 2014 09:44:33 +0200 In-Reply-To: <1402223455.15729.185.camel@hastur.hellion.org.uk> References: <1400756406-22617-1-git-send-email-kraxel@redhat.com> <1400756406-22617-3-git-send-email-kraxel@redhat.com> <1402223455.15729.185.camel@hastur.hellion.org.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Campbell Cc: qemu-devel@nongnu.org, Anthony Liguori On So, 2014-06-08 at 11:30 +0100, Ian Campbell wrote: > On Thu, 2014-05-22 at 13:00 +0200, Gerd Hoffmann wrote: > > Have a global timer. Update all visible terminal windows syncronously. > > Right now this can be the active_console only, but that will change > > soon. The global timer will disable itself if not needed, so we only > > have to care start it if needed. Which might be at console switch time > > or when a new displaychangelistener is registered. > > Running current master (d7d3d6092cb7) I'm seeing a segmentation fault > while running: > ./aarch64-softmmu/qemu-system-aarch64 -M virt -cpu cortex-a57 > -sdl > which goes away if I revert this patch. qemu is configured with > ./configure --target-list=aarch64-softmmu --enable-sdl > > The backtrace shows that the timer is NULL. http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00106.html High time to get the pull request out of the door ... cheers, Gerd