From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free()
Date: Tue, 10 Jun 2014 10:03:22 +0200 [thread overview]
Message-ID: <1402387402.8739.22.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <877g4uc69u.fsf@blackfin.pond.sub.org>
> >> + *cred = NULL;
> >>
> >> *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
> >
> > Still a dead store
>
> No deader than before my patch :)
>
> Still, it's as good an opportunity to drop it as any. Gerd, would you
> like a v3?
It's an improvement in any case, so I'm not going to reject it.
Nevertheless a v3 would be nice though.
cheers,
Gerd
next prev parent reply other threads:[~2014-06-10 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 16:47 [Qemu-devel] [PATCH v2 0/2] vnc: Drop some superfluous conditionals Markus Armbruster
2014-06-06 16:47 ` [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free() Markus Armbruster
2014-06-06 17:02 ` Eric Blake
2014-06-06 17:11 ` Markus Armbruster
2014-06-10 8:03 ` Gerd Hoffmann [this message]
2014-06-06 16:47 ` [Qemu-devel] [PATCH v2 2/2] vnc: Drop superfluous conditionals around g_strdup() Markus Armbruster
2014-06-06 17:03 ` Eric Blake
2014-06-12 11:40 ` [Qemu-devel] [PATCH v2 0/2] vnc: Drop some superfluous conditionals Gerd Hoffmann
2014-06-12 12:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402387402.8739.22.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).