From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuH1p-00011f-Bk for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:03:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuH1j-0006hC-7u for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:03:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuH1j-0006gw-08 for qemu-devel@nongnu.org; Tue, 10 Jun 2014 04:03:27 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5A83PKG021750 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 10 Jun 2014 04:03:25 -0400 Message-ID: <1402387402.8739.22.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Tue, 10 Jun 2014 10:03:22 +0200 In-Reply-To: <877g4uc69u.fsf@blackfin.pond.sub.org> References: <1402073264-9606-1-git-send-email-armbru@redhat.com> <1402073264-9606-2-git-send-email-armbru@redhat.com> <5391F41F.4090407@redhat.com> <877g4uc69u.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org > >> + *cred = NULL; > >> > >> *cred = g_malloc(strlen(certdir) + strlen(filename) + 2); > > > > Still a dead store > > No deader than before my patch :) > > Still, it's as good an opportunity to drop it as any. Gerd, would you > like a v3? It's an improvement in any case, so I'm not going to reject it. Nevertheless a v3 would be nice though. cheers, Gerd