qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v4 4/9] virtio-blk: Drop VirtIOBlockRequest.read
Date: Wed, 11 Jun 2014 12:11:45 +0800	[thread overview]
Message-ID: <1402459910-18889-5-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1402459910-18889-1-git-send-email-famz@redhat.com>

Since it's set but not used.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/block/dataplane/virtio-blk.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 3d1e9e1..4e5e458 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -29,7 +29,6 @@ typedef struct {
     QEMUIOVector *inhdr;            /* iovecs for virtio_blk_inhdr */
     VirtQueueElement *elem;         /* saved data from the virtqueue */
     QEMUIOVector qiov;              /* original request iovecs */
-    bool read;                      /* read or write? */
 } VirtIOBlockRequest;
 
 struct VirtIOBlockDataPlane {
@@ -137,7 +136,6 @@ static void do_rdwr_cmd(VirtIOBlockDataPlane *s, bool read,
     req->s = s;
     req->elem = elem;
     req->inhdr = inhdr;
-    req->read = read;
     qemu_iovec_init_external(&req->qiov, iov, iov_cnt);
 
     qiov = &req->qiov;
-- 
2.0.0

  parent reply	other threads:[~2014-06-11  4:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  4:11 [Qemu-devel] [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Fam Zheng
2014-06-11  4:11 ` [Qemu-devel] [PATCH v4 1/9] virtio-blk: Move VirtIOBlockReq to header Fam Zheng
2014-06-11  4:11 ` [Qemu-devel] [PATCH v4 2/9] virtio-blk: Convert VirtIOBlockReq.elem to pointer Fam Zheng
2014-06-11  4:11 ` [Qemu-devel] [PATCH v4 3/9] virtio-blk: Drop bounce buffer from dataplane code Fam Zheng
2014-06-11  4:11 ` Fam Zheng [this message]
2014-06-11  4:11 ` [Qemu-devel] [PATCH v4 5/9] virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq Fam Zheng
2014-06-11  4:11 ` [Qemu-devel] [PATCH v4 6/9] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr Fam Zheng
2014-06-11  4:11 ` [Qemu-devel] [PATCH v4 7/9] virtio-blk: Convert VirtIOBlockReq.out to structrue Fam Zheng
2014-06-11  4:11 ` [Qemu-devel] [PATCH v4 8/9] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code Fam Zheng
2014-06-11  4:11 ` [Qemu-devel] [PATCH v4 9/9] virtio-blk: Fix and clean up the in_sg and out_sg check Fam Zheng
2014-06-27 13:29 ` [Qemu-devel] [PATCH v4 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq Stefan Hajnoczi
2014-06-27 16:19   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402459910-18889-5-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).