From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WudXT-0006tg-Vn for qemu-devel@nongnu.org; Wed, 11 Jun 2014 04:05:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WudXL-0002Wn-J3 for qemu-devel@nongnu.org; Wed, 11 Jun 2014 04:05:43 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:46410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WudXK-0002WO-MJ for qemu-devel@nongnu.org; Wed, 11 Jun 2014 04:05:35 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Jun 2014 18:05:27 +1000 From: Alexey Kardashevskiy Date: Wed, 11 Jun 2014 18:05:20 +1000 Message-Id: <1402473920-4763-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH] spapr_pci: Advertise MSI quota List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, Badari Pulavarty , Alexander Graf From: Badari Pulavarty Hotplug of multiple disks fails due to MSI vector quota check. Number of MSI vectors default to 8 allowing only 4 devices. This happens on RHEL6.5 guest. RHEL7 and SLES11 guests fallback to INTX. One way to workaround the issue is to increase total MSIs, so that MSI quota check allows us to hotplug multiple disks. Signed-off-by: Badari Pulavarty Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index ddfd8bb..ebd92fd 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -831,6 +831,7 @@ int spapr_populate_pci_dt(sPAPRPHBState *phb, int bus_off, i, j; char nodename[256]; uint32_t bus_range[] = { cpu_to_be32(0), cpu_to_be32(0xff) }; + uint16_t nmsi = 64; struct { uint32_t hi; uint64_t child; @@ -879,6 +880,7 @@ int spapr_populate_pci_dt(sPAPRPHBState *phb, _FDT(fdt_setprop(fdt, bus_off, "ranges", &ranges, sizeof(ranges))); _FDT(fdt_setprop(fdt, bus_off, "reg", &bus_reg, sizeof(bus_reg))); _FDT(fdt_setprop_cell(fdt, bus_off, "ibm,pci-config-space-type", 0x1)); + _FDT(fdt_setprop(fdt, bus_off, "ibm,pe-total-#msi", &nmsi, sizeof(nmsi))); /* Build the interrupt-map, this must matches what is done * in pci_spapr_map_irq -- 2.0.0