From: Gerd Hoffmann <kraxel@redhat.com>
To: David Marchand <david.marchand@6wind.com>
Cc: pbonzini@redhat.com, cam@cs.ualberta.ca, qemu-devel@nongnu.org,
aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH v2] char: fix avail_connections init in qemu_chr_open_eventfd()
Date: Thu, 12 Jun 2014 11:10:19 +0200 [thread overview]
Message-ID: <1402564219.7148.4.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1402500316-6894-1-git-send-email-david.marchand@6wind.com>
On Mi, 2014-06-11 at 17:25 +0200, David Marchand wrote:
> When trying to use a ivshmem server with qemu, ivshmem init code tries to
> create a CharDriverState object for each eventfd retrieved from the server.
> To create this object, a call to qemu_chr_open_eventfd() is done.
> Right after this, before adding a frontend, qemu_chr_fe_claim_no_fail() is
> called.
> qemu_chr_open_eventfd() does not set avail_connections to 1, so no frontend can
> be associated because qemu_chr_fe_claim_no_fail() makes qemu stop right away.
>
> This problem comes from 456d60692310e7ac25cf822cc1e98192ad636ece
> "qemu-char: Call fe_claim / fe_release when not using qdev chr properties".
>
> Fix this, by setting avail_connections to 1 in qemu_chr_open_eventfd().
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
Picked up.
cheers,
Gerd
prev parent reply other threads:[~2014-06-12 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 21:17 [Qemu-devel] [PATCH RFC] char: fix avail_connections init in qemu_chr_open_eventfd() David Marchand
2014-02-13 14:47 ` David Marchand
2014-02-13 18:58 ` Cam Macdonell
2014-02-14 12:16 ` David Marchand
2014-02-17 11:52 ` David Marchand
2014-02-21 16:10 ` David Marchand
2014-03-27 15:20 ` David Marchand
2014-06-11 13:39 ` [Qemu-devel] [PATCH] " David Marchand
2014-06-11 14:56 ` Paolo Bonzini
2014-06-11 15:25 ` [Qemu-devel] [PATCH v2] " David Marchand
2014-06-12 9:10 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402564219.7148.4.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=cam@cs.ualberta.ca \
--cc=david.marchand@6wind.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).