From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wv1C3-0007Yv-P1 for qemu-devel@nongnu.org; Thu, 12 Jun 2014 05:21:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wv1Bu-0003PL-ET for qemu-devel@nongnu.org; Thu, 12 Jun 2014 05:21:11 -0400 Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 12 Jun 2014 11:20:53 +0200 Message-Id: <1402564853-20792-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] virtio-serial: remove useless set_config function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, amit.shah@redhat.com Its only contents are a dead memcpy. Since it is optional, drop the function altogether. Signed-off-by: Paolo Bonzini --- hw/char/virtio-serial-bus.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 2b647b6..a2958ff 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial-bus.c @@ -465,13 +465,6 @@ static void get_config(VirtIODevice *vdev, uint8_t *config_data) memcpy(config_data, &vser->config, sizeof(struct virtio_console_config)); } -static void set_config(VirtIODevice *vdev, const uint8_t *config_data) -{ - struct virtio_console_config config; - - memcpy(&config, config_data, sizeof(config)); -} - static void guest_reset(VirtIOSerial *vser) { VirtIOSerialPort *port; @@ -1024,7 +1017,6 @@ static void virtio_serial_class_init(ObjectClass *klass, void *data) vdc->unrealize = virtio_serial_device_unrealize; vdc->get_features = get_features; vdc->get_config = get_config; - vdc->set_config = set_config; vdc->set_status = set_status; vdc->reset = vser_reset; } -- 1.9.3