From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvPVK-0007Xh-9F for qemu-devel@nongnu.org; Fri, 13 Jun 2014 07:18:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvPVF-0002Jy-78 for qemu-devel@nongnu.org; Fri, 13 Jun 2014 07:18:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvPVE-0002Jp-V7 for qemu-devel@nongnu.org; Fri, 13 Jun 2014 07:18:37 -0400 From: Gerd Hoffmann Date: Fri, 13 Jun 2014 13:18:29 +0200 Message-Id: <1402658309-8841-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1402658309-8841-1-git-send-email-kraxel@redhat.com> References: <1402658309-8841-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 1/1] char: fix avail_connections init in qemu_chr_open_eventfd() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: David Marchand , Anthony Liguori , Gerd Hoffmann From: David Marchand When trying to use a ivshmem server with qemu, ivshmem init code tries to create a CharDriverState object for each eventfd retrieved from the server. To create this object, a call to qemu_chr_open_eventfd() is done. Right after this, before adding a frontend, qemu_chr_fe_claim_no_fail() is called. qemu_chr_open_eventfd() does not set avail_connections to 1, so no frontend can be associated because qemu_chr_fe_claim_no_fail() makes qemu stop right away. This problem comes from 456d60692310e7ac25cf822cc1e98192ad636ece "qemu-char: Call fe_claim / fe_release when not using qdev chr properties". Fix this, by setting avail_connections to 1 in qemu_chr_open_eventfd(). Signed-off-by: David Marchand Signed-off-by: Gerd Hoffmann --- qemu-char.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 4c04bbc..f918f90 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2493,7 +2493,13 @@ static gboolean tcp_chr_read(GIOChannel *chan, GIOCondition cond, void *opaque) #ifndef _WIN32 CharDriverState *qemu_chr_open_eventfd(int eventfd) { - return qemu_chr_open_fd(eventfd, eventfd); + CharDriverState *chr = qemu_chr_open_fd(eventfd, eventfd); + + if (chr) { + chr->avail_connections = 1; + } + + return chr; } #endif -- 1.8.3.1