[Qemu-devel] [PULL 0/1] usb-host: add range checks for usb-host parameters

[Qemu-devel] [PULL 0/1] usb-host: add range checks for usb-host parameters

[Gerd Hoffmann]

  Hi,

usb patch queue is pretty short too, with a
single patch adding ubs-host parameter checks.

please pull,
  Gerd

The following changes since commit 2a2c4830c0068d70443f3dddc4cc668f0c601b5c:

  Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20140611-1' into staging (2014-06-12 09:51:41 +0100)

are available in the git repository at:


  git://git.kraxel.org/qemu tags/pull-usb-20140613-1

for you to fetch changes up to f3cda6e060c483dee1fa497699fd5f972e5031da:

  usb-host: add range checks for usb-host parameters (2014-06-13 12:34:57 +0200)

----------------------------------------------------------------
usb-host: add range checks for usb-host parameters

----------------------------------------------------------------
Gerd Hoffmann (1):
      usb-host: add range checks for usb-host parameters

 hw/usb/host-libusb.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

[Qemu-devel] [PULL 1/1] usb-host: add range checks for usb-host parameters

[Gerd Hoffmann]

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/host-libusb.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index afbf156..33b5b9f 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -952,6 +952,19 @@ static int usb_host_initfn(USBDevice *udev)
 {
     USBHostDevice *s = USB_HOST_DEVICE(udev);
 
+    if (s->match.vendor_id > 0xffff) {
+        error_report("vendorid out of range");
+        return -1;
+    }
+    if (s->match.product_id > 0xffff) {
+        error_report("productid out of range");
+        return -1;
+    }
+    if (s->match.addr > 127) {
+        error_report("hostaddr out of range");
+        return -1;
+    }
+
     loglevel = s->loglevel;
     udev->flags |= (1 << USB_DEV_FLAG_IS_HOST);
     udev->auto_attach = 0;
-- 
1.8.3.1

Re: [Qemu-devel] [PULL 0/1] usb-host: add range checks for usb-host parameters

[Peter Maydell]

On 13 June 2014 12:35, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> usb patch queue is pretty short too, with a
> single patch adding ubs-host parameter checks.
>
> please pull,
>   Gerd
>
> The following changes since commit 2a2c4830c0068d70443f3dddc4cc668f0c601b5c:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20140611-1' into staging (2014-06-12 09:51:41 +0100)
>
> are available in the git repository at:
>
>
>   git://git.kraxel.org/qemu tags/pull-usb-20140613-1
>
> for you to fetch changes up to f3cda6e060c483dee1fa497699fd5f972e5031da:
>
>   usb-host: add range checks for usb-host parameters (2014-06-13 12:34:57 +0200)
>
> ----------------------------------------------------------------
> usb-host: add range checks for usb-host parameters
>
> ----------------------------------------------------------------
> Gerd Hoffmann (1):
>       usb-host: add range checks for usb-host parameters
>
>  hw/usb/host-libusb.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>

Applied, thanks.

-- PMM