From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwY8H-0000Do-U1 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 10:43:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwY8B-0005WW-HG for qemu-devel@nongnu.org; Mon, 16 Jun 2014 10:43:37 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:48117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwY8B-0005WB-8l for qemu-devel@nongnu.org; Mon, 16 Jun 2014 10:43:31 -0400 Received: by mail-we0-f172.google.com with SMTP id u57so5897892wes.31 for ; Mon, 16 Jun 2014 07:43:30 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 16 Jun 2014 16:43:25 +0200 Message-Id: <1402929805-16836-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] rules.mak: remove $(sort) from extract-libs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, sbruno@ignoranthack.me Duplicate removal was added to extract-libs in order to avoid including the same library multiple times into the linking command line; this could potentially happen when using "foo.mo-libs" (which adds the library to all components, causing it to appear N times if the module is composed of N objects). However, sorting and removing duplicates causes problems with static linking, and also with space-separated linker options as found in some Mac OS X packaging systems. Furthermore, the "optimization" is really a non-problem since we do not expect .mo modules to be composed of many files. Reported-by: Sean Bruno Tested-by: Sean Bruno Signed-off-by: Paolo Bonzini --- Peter, can you please apply this directly as it fixes the build and there are no other pending patches? --- rules.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules.mak b/rules.mak index dde8e00..945484e 100644 --- a/rules.mak +++ b/rules.mak @@ -22,7 +22,7 @@ QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d # Same as -I$(SRC_PATH) -I., but for the nested source/object directories QEMU_INCLUDES += -I$(