From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwYff-0006rv-Gs for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:18:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwYfW-0002bL-Go for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:18:07 -0400 Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:59118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwYfW-0002b7-99 for qemu-devel@nongnu.org; Mon, 16 Jun 2014 11:17:58 -0400 Received: by mail-we0-f171.google.com with SMTP id q58so5821991wes.2 for ; Mon, 16 Jun 2014 08:17:57 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 16 Jun 2014 17:17:44 +0200 Message-Id: <1402931870-17261-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1402931870-17261-1-git-send-email-pbonzini@redhat.com> References: <1402931870-17261-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 1/7] util: add return value to qemu_iovec_concat_iov List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com This will be necessary later to recognize the case where a request has both dataout and datain. Signed-off-by: Paolo Bonzini --- include/qemu-common.h | 6 +++--- util/iov.c | 10 ++++++---- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/include/qemu-common.h b/include/qemu-common.h index 66ceceb..ae76197 100644 --- a/include/qemu-common.h +++ b/include/qemu-common.h @@ -315,9 +315,9 @@ void qemu_iovec_init_external(QEMUIOVector *qiov, struct iovec *iov, int niov); void qemu_iovec_add(QEMUIOVector *qiov, void *base, size_t len); void qemu_iovec_concat(QEMUIOVector *dst, QEMUIOVector *src, size_t soffset, size_t sbytes); -void qemu_iovec_concat_iov(QEMUIOVector *dst, - struct iovec *src_iov, unsigned int src_cnt, - size_t soffset, size_t sbytes); +size_t qemu_iovec_concat_iov(QEMUIOVector *dst, + struct iovec *src_iov, unsigned int src_cnt, + size_t soffset, size_t sbytes); bool qemu_iovec_is_zero(QEMUIOVector *qiov); void qemu_iovec_destroy(QEMUIOVector *qiov); void qemu_iovec_reset(QEMUIOVector *qiov); diff --git a/util/iov.c b/util/iov.c index 49f8838..2b4f46d 100644 --- a/util/iov.c +++ b/util/iov.c @@ -295,15 +295,15 @@ void qemu_iovec_add(QEMUIOVector *qiov, void *base, size_t len) * of src". * Only vector pointers are processed, not the actual data buffers. */ -void qemu_iovec_concat_iov(QEMUIOVector *dst, - struct iovec *src_iov, unsigned int src_cnt, - size_t soffset, size_t sbytes) +size_t qemu_iovec_concat_iov(QEMUIOVector *dst, + struct iovec *src_iov, unsigned int src_cnt, + size_t soffset, size_t sbytes) { int i; size_t done; if (!sbytes) { - return; + return 0; } assert(dst->nalloc != -1); for (i = 0, done = 0; done < sbytes && i < src_cnt; i++) { @@ -317,6 +317,8 @@ void qemu_iovec_concat_iov(QEMUIOVector *dst, } } assert(soffset == 0); /* offset beyond end of src */ + + return done; } /* -- 1.8.3.1