From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: [Qemu-devel] [PATCH v2 4/7] virtio-scsi: add extra argument and return type to qemu_sgl_concat
Date: Mon, 16 Jun 2014 17:17:47 +0200 [thread overview]
Message-ID: <1402931870-17261-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1402931870-17261-1-git-send-email-pbonzini@redhat.com>
Will be used for anylayout support.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/virtio-scsi.c | 27 ++++++++++++++++++++-------
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index ec9a536..0718626 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -95,14 +95,27 @@ static void virtio_scsi_bad_req(void)
exit(1);
}
-static void qemu_sgl_concat(VirtIOSCSIReq *req, struct iovec *sg,
- hwaddr *addr, int num)
+static size_t qemu_sgl_concat(VirtIOSCSIReq *req, struct iovec *iov,
+ hwaddr *addr, int num, size_t skip)
{
QEMUSGList *qsgl = &req->qsgl;
-
- while (num--) {
- qemu_sglist_add(qsgl, *(addr++), (sg++)->iov_len);
+ size_t copied = 0;
+
+ while (num) {
+ if (skip >= iov->iov_len) {
+ skip -= iov->iov_len;
+ } else {
+ qemu_sglist_add(qsgl, *addr + skip, iov->iov_len - skip);
+ copied += iov->iov_len - skip;
+ skip = 0;
+ }
+ iov++;
+ addr++;
+ num--;
}
+
+ assert(skip == 0);
+ return copied;
}
static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
@@ -127,11 +140,11 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,
if (req->elem.out_num > 1) {
qemu_sgl_concat(req, &req->elem.out_sg[1],
&req->elem.out_addr[1],
- req->elem.out_num - 1);
+ req->elem.out_num - 1, 0);
} else {
qemu_sgl_concat(req, &req->elem.in_sg[1],
&req->elem.in_addr[1],
- req->elem.in_num - 1);
+ req->elem.in_num - 1, 0);
}
return 0;
--
1.8.3.1
next prev parent reply other threads:[~2014-06-16 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 15:17 [Qemu-devel] [PATCH v2 0/7] virtio-scsi: do not rely on iov boundaries Paolo Bonzini
2014-06-16 15:17 ` [Qemu-devel] [PATCH v2 1/7] util: add return value to qemu_iovec_concat_iov Paolo Bonzini
2014-06-16 15:17 ` [Qemu-devel] [PATCH v2 2/7] virtio-scsi: start preparing for any_layout Paolo Bonzini
2014-06-16 15:17 ` [Qemu-devel] [PATCH v2 3/7] virtio-scsi: add target swap for VirtIOSCSICtrlTMFReq fields Paolo Bonzini
2014-06-16 15:17 ` Paolo Bonzini [this message]
2014-06-16 15:17 ` [Qemu-devel] [PATCH v2 5/7] virtio-scsi: prepare sense data handling for any_layout Paolo Bonzini
2014-06-16 15:17 ` [Qemu-devel] [PATCH v2 6/7] virtio-scsi: introduce virtio_scsi_complete_cmd_req Paolo Bonzini
2014-06-16 15:17 ` [Qemu-devel] [PATCH v2 7/7] virtio-scsi: add support for the any_layout feature Paolo Bonzini
2014-06-18 16:17 ` [Qemu-devel] [PATCH v2 0/7] virtio-scsi: do not rely on iov boundaries Michael S. Tsirkin
2014-06-18 16:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402931870-17261-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).