From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwmDZ-0005lk-Ow for qemu-devel@nongnu.org; Tue, 17 Jun 2014 01:46:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwmDT-0007JJ-QL for qemu-devel@nongnu.org; Tue, 17 Jun 2014 01:46:01 -0400 Received: from mail-pa0-x22c.google.com ([2607:f8b0:400e:c03::22c]:63819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwmDT-0007If-K2 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 01:45:55 -0400 Received: by mail-pa0-f44.google.com with SMTP id rd3so4035781pab.31 for ; Mon, 16 Jun 2014 22:45:53 -0700 (PDT) From: Liu Yuan Date: Tue, 17 Jun 2014 13:45:35 +0800 Message-Id: <1402983935-14920-1-git-send-email-namei.unix@gmail.com> Subject: [Qemu-devel] [PATCH] sheepdog: fix NULL dereference in sd_create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sheepdog@lists.wpkg.org Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi Following command qemu-img create -f qcow2 sheepdog:test 20g will cause core dump because aio_context is NULL in sd_create. We should initialize it by qemu_get_aio_context() to avoid NULL dereference. Cc: qemu-devel@nongnu.org Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 1fa1939..47a8b5a 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -1761,6 +1761,7 @@ static int sd_create(const char *filename, QEMUOptionParameter *options, bdrv_unref(bs); } + s->aio_context = qemu_get_aio_context(); ret = do_sd_create(s, &vid, 0, errp); if (ret) { goto out; -- 1.8.1.2