From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1WwmXq-0007mM-Ra
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 02:07:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1WwmXk-0006EE-HB
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 02:06:58 -0400
Received: from gate.crashing.org ([63.228.1.57]:56566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1WwmXk-0006CQ-93
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 02:06:52 -0400
Message-ID: <1402985200.7661.112.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Tue, 17 Jun 2014 16:06:40 +1000
In-Reply-To: <539FD3F1.2010304@redhat.com>
References: <1402974463.7661.102.camel@pasglop>
	<539FC6B9.6060003@redhat.com> <1402981184.7661.107.camel@pasglop>
	<539FD3F1.2010304@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing
	changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On Tue, 2014-06-17 at 07:36 +0200, Paolo Bonzini wrote:
> Il 17/06/2014 06:59, Benjamin Herrenschmidt ha scritto:
> > Thanks. I've tried the other approach of adding new functions which
> > means no overhead (hopefully) for the non-swap case and less invasive
> > changes to vga_template.c.
> >
> > Patch below. What do you think ? This or the previous approach ? Then we
> > can discuss how we actually trigger the endian change and where we store
> > the state :-)
> 
> This is definitely more readable.  Anyway Gerd is the VGA guy. :)

Allright, let's wait for his opinion.

Cheers,
Ben.