[Qemu-devel] [PATCH] armv7m_nvic: fix AIRCR implementation

[Qemu-devel] [PATCH] armv7m_nvic: fix AIRCR implementation

[Oran Avraham]

The returned reset value was wrong (off by one zero nibble), and
qemu didn't log unimplemented writes to the PRIGROUP field.

Signed-off-by: Oran Avraham <oranav@gmail.com>
---
 hw/intc/armv7m_nvic.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
index 75d9c6e..1a7af45 100644
--- a/hw/intc/armv7m_nvic.c
+++ b/hw/intc/armv7m_nvic.c
@@ -211,7 +211,7 @@ static uint32_t nvic_readl(nvic_state *s, uint32_t offset)
         cpu = ARM_CPU(current_cpu);
         return cpu->env.v7m.vecbase;
     case 0xd0c: /* Application Interrupt/Reset Control.  */
-        return 0xfa05000;
+        return 0xfa050000;
     case 0xd10: /* System Control.  */
         /* TODO: Implement SLEEPONEXIT.  */
         return 0;
@@ -346,6 +346,9 @@ static void nvic_writel(nvic_state *s, uint32_t offset, uint32_t value)
             if (value & 5) {
                 qemu_log_mask(LOG_UNIMP, "AIRCR system reset unimplemented\n");
             }
+            if (value & 0x700) {
+                qemu_log_mask(LOG_UNIMP, "PRIGROUP unimplemented\n");
+            }
         }
         break;
     case 0xd10: /* System Control.  */
-- 
1.9.1

Re: [Qemu-devel] [PATCH] armv7m_nvic: fix AIRCR implementation

[Peter Maydell]

On 17 June 2014 14:07, Oran Avraham <oranav@gmail.com> wrote:
> The returned reset value was wrong (off by one zero nibble), and
> qemu didn't log unimplemented writes to the PRIGROUP field.
>
> Signed-off-by: Oran Avraham <oranav@gmail.com>
> ---

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM