From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx03I-0005ND-AU for qemu-devel@nongnu.org; Tue, 17 Jun 2014 16:32:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wx03D-0007eh-Cf for qemu-devel@nongnu.org; Tue, 17 Jun 2014 16:32:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx03D-0007eP-5Y for qemu-devel@nongnu.org; Tue, 17 Jun 2014 16:32:15 -0400 From: Eduardo Habkost Date: Tue, 17 Jun 2014 17:31:53 -0300 Message-Id: <1403037113-7823-3-git-send-email-ehabkost@redhat.com> In-Reply-To: <1403037113-7823-1-git-send-email-ehabkost@redhat.com> References: <1403037113-7823-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [qom-cpu PATCH v3 2/2] target-i386: Set migratable=yes by default on "host" CPU mooel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, =?UTF-8?q?Andreas=20F=C3=A4rber?= Cc: Paolo Bonzini , Richard Henderson , Marcelo Tosatti , Aurelien Jarno , Igor Mammedov Having only migratable flags reported by default on the "host" CPU model is safer for the following reasons: * Existing users may expect "-cpu host" to be migration-safe, if they take care of always using compatible host CPUs, host kernels, and QEMU versions. * Users who don't care aboug migration and want to enable all features supported by the host kernel can simply change their setup to use migratable=no. Without this change, people using "-cpu host" will stop being able to migrate, because now "invtsc" is getting enabled by default. We are not setting migratable=yes by default on all X86CPU subclasses, because users should be able to get non-migratable features enabled if they ask for them explicitly. Reviewed-by: Marcelo Tosatti Signed-off-by: Eduardo Habkost --- For a discussion about why it makes sense to set it by default, see: http://marc.info/?l=qemu-devel&m=139838802220184&w=2 --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 5db0338..8c80dea 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1240,7 +1240,7 @@ static int cpu_x86_fill_model_id(char *str) static X86CPUDefinition host_cpudef; static Property host_x86_cpu_properties[] = { - DEFINE_PROP_BOOL("migratable", X86CPU, migratable, false), + DEFINE_PROP_BOOL("migratable", X86CPU, migratable, true), DEFINE_PROP_END_OF_LIST() }; -- 1.9.3