From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers
Date: Wed, 18 Jun 2014 00:14:08 +0200 [thread overview]
Message-ID: <1403043250-28472-1-git-send-email-mreitz@redhat.com> (raw)
For some protocol block drivers, the "filename" attribute in their BDSs
is unset due to bdrv_file_open() removing it from the options QDict
before bdrv_open_common() is able to copy it into the BDS. Fix this by
not removing it until until bdrv_open_common() has indeed copied it.
Max Reitz (2):
block: Do not prematurely remove "filename"
iotests: Add test for set "filename" for NBD
block.c | 12 ++++++--
tests/qemu-iotests/097 | 72 ++++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/097.out | 13 +++++++++
tests/qemu-iotests/group | 1 +
4 files changed, 95 insertions(+), 3 deletions(-)
create mode 100755 tests/qemu-iotests/097
create mode 100644 tests/qemu-iotests/097.out
--
2.0.0
next reply other threads:[~2014-06-17 22:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 22:14 Max Reitz [this message]
2014-06-17 22:14 ` [Qemu-devel] [PATCH 1/2] block: Do not prematurely remove "filename" Max Reitz
2014-06-18 13:42 ` Benoît Canet
2014-06-17 22:14 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for set "filename" for NBD Max Reitz
2014-06-18 13:47 ` Benoît Canet
2014-06-18 18:14 ` Max Reitz
2014-06-19 6:24 ` [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers Stefan Hajnoczi
2014-06-23 8:35 ` Stefan Hajnoczi
2014-06-26 18:58 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403043250-28472-1-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).