From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx4oa-0007xU-Gq for qemu-devel@nongnu.org; Tue, 17 Jun 2014 21:37:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wx4oW-0005pM-AC for qemu-devel@nongnu.org; Tue, 17 Jun 2014 21:37:28 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:39042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx4oV-0005oz-Us for qemu-devel@nongnu.org; Tue, 17 Jun 2014 21:37:24 -0400 Message-ID: <1403055439.32307.2.camel@concordia> From: Michael Ellerman Date: Wed, 18 Jun 2014 11:37:19 +1000 In-Reply-To: <53A0E489.1040901@suse.de> References: <1402991675-24905-1-git-send-email-mpe@ellerman.id.au> <1402991675-24905-6-git-send-email-mpe@ellerman.id.au> <539FFC0C.6060105@suse.de> <1403052608.32307.1.camel@concordia> <53A0E489.1040901@suse.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] kvm_stat: Add powerpc support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: graalfs@linux.vnet.ibm.com, kvm@vger.kernel.org, aik@ozlabs.ru, jan.kiszka@siemens.com, qemu-devel@nongnu.org, jfrei@linux.vnet.ibm.com, pbonzini@redhat.com On Wed, 2014-06-18 at 02:59 +0200, Alexander Graf wrote: > On 18.06.14 02:50, Michael Ellerman wrote: > > On Tue, 2014-06-17 at 10:27 +0200, Alexander Graf wrote: > >> On 17.06.14 09:54, Michael Ellerman wrote: > >>> Add support for powerpc platforms. We use uname -m, which allows us to > >>> detect ppc, ppc64 and ppc64le/el. > >>> > >>> Signed-off-by: Michael Ellerman > >> Could you please add support for PR KVM tracepoints along the way? There > >> we do know the exit reason for every single guest <-> host transition. I > >> would like to move to a similar model with HV in the future, so we can > >> hopefully just reuse this by then. > > So I think what you're saying is you want it to somehow support using > > 'kvm_exit' for PR and 'kvm_userspace_exit' for HV? > > "kvm_userspace_exit" is implemented on both HV and PR. "kvm_exit" is PR > only, but I'm hoping we can get it working in HV as well. > > > Or actually use 'kvm_exit' if it exists and fall back to 'kvm_userspace_exit', > > so that if HV starts providing 'kvm_exit' the script will pick that up without > > further changes. > > They are completely different things. "kvm_userspace_exit" tells us > which exits we take from KVM -> QEMU. "kvm_exit" tells us which exits we > take from guest -> KVM. > > In fact, IIRC x86 also implements kvm_userspace_exit - or at least > something very similar to it. It's a completely separate category. Right. Everyone implements kvm_userspace_exit, it's in virt/kvm/kvm_main.c > Maybe it should be a command line switch to distinguish between the count types? Or just we always read the kvm_userspace_exit counts, and if we find kvm_exit we expose that as well - with an arch specific set of reasons. cheers