From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, Paolo Bonzini <pbonzini@redhat.com>,
peter.crosthwaite@xilinx.com, Andreas Faerber <afaerber@suse.de>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v4 5/9] qdev: add qdev_alias_all_properties()
Date: Wed, 18 Jun 2014 17:58:32 +0800 [thread overview]
Message-ID: <1403085516-10340-6-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1403085516-10340-1-git-send-email-stefanha@redhat.com>
The qdev_alias_all_properties() function creates QOM alias properties
for each qdev property on a DeviceState. This is useful for parent
objects that wish to forward property accesses to their children.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
v3:
* Split qdev_alias_all_properties() into its own patch [Peter Crosthwaite]
* Do not dereference DEVICE_CLASS(class) inline [Peter Crosthwaite]
---
hw/core/qdev.c | 21 +++++++++++++++++++++
include/hw/qdev-properties.h | 2 ++
2 files changed, 23 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index e65a5aa..850cd9e 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -776,6 +776,27 @@ void qdev_property_add_static(DeviceState *dev, Property *prop,
}
}
+/* @qdev_alias_all_properties - Add alias properties to the source object for
+ * all qdev properties on the target DeviceState.
+ */
+void qdev_alias_all_properties(DeviceState *target, Object *source)
+{
+ ObjectClass *class;
+ Property *prop;
+
+ class = object_get_class(OBJECT(target));
+ do {
+ DeviceClass *dc = DEVICE_CLASS(class);
+
+ for (prop = dc->props; prop && prop->name; prop++) {
+ object_property_add_alias(source, prop->name,
+ OBJECT(target), prop->name,
+ &error_abort);
+ }
+ class = object_class_get_parent(class);
+ } while (class != object_class_by_name(TYPE_DEVICE));
+}
+
static bool device_get_realized(Object *obj, Error **errp)
{
DeviceState *dev = DEVICE(obj);
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index c962b6b..3726bf3 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -193,6 +193,8 @@ void error_set_from_qdev_prop_error(Error **errp, int ret, DeviceState *dev,
*/
void qdev_property_add_static(DeviceState *dev, Property *prop, Error **errp);
+void qdev_alias_all_properties(DeviceState *target, Object *source);
+
/**
* @qdev_prop_set_after_realize:
* @dev: device
--
1.9.3
next prev parent reply other threads:[~2014-06-18 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 9:58 [Qemu-devel] [PATCH v4 0/9] virtio-blk: use alias properties in transport devices Stefan Hajnoczi
2014-06-18 9:58 ` [Qemu-devel] [PATCH v4 1/9] qom: add object_property_add_alias() Stefan Hajnoczi
2014-06-18 9:58 ` [Qemu-devel] [PATCH v4 2/9] virtio-blk: avoid qdev property definition duplication Stefan Hajnoczi
2014-06-18 9:58 ` [Qemu-devel] [PATCH v4 3/9] dataplane: bail out on unsupported transport Stefan Hajnoczi
2014-06-18 9:58 ` [Qemu-devel] [PATCH v4 4/9] virtio-blk: move x-data-plane qdev property to virtio-blk.h Stefan Hajnoczi
2014-06-18 9:58 ` Stefan Hajnoczi [this message]
2014-06-18 9:58 ` [Qemu-devel] [PATCH v4 6/9] virtio-blk: use aliases instead of duplicate qdev properties Stefan Hajnoczi
2014-06-18 9:58 ` [Qemu-devel] [PATCH v4 7/9] virtio-blk: drop virtio_blk_set_conf() Stefan Hajnoczi
2014-06-18 9:58 ` [Qemu-devel] [PATCH v4 8/9] virtio: fix virtio-blk child refcount in transports Stefan Hajnoczi
2014-06-25 9:25 ` Peter Crosthwaite
2014-06-18 9:58 ` [Qemu-devel] [PATCH v4 9/9] virtio-blk: move qdev properties into virtio-blk.c Stefan Hajnoczi
2014-06-24 12:22 ` [Qemu-devel] [PATCH v4 0/9] virtio-blk: use alias properties in transport devices Paolo Bonzini
2014-06-30 8:47 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403085516-10340-6-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).