qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: cornelia.huck@de.ibm.com, Paolo Bonzini <pbonzini@redhat.com>,
	peter.crosthwaite@xilinx.com, Andreas Faerber <afaerber@suse.de>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v4 7/9] virtio-blk: drop virtio_blk_set_conf()
Date: Wed, 18 Jun 2014 17:58:34 +0800	[thread overview]
Message-ID: <1403085516-10340-8-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1403085516-10340-1-git-send-email-stefanha@redhat.com>

This function is no longer used since parent objects now use child
aliases to set the VirtIOBlkConf directly.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
 hw/block/virtio-blk.c          | 6 ------
 include/hw/virtio/virtio-blk.h | 2 --
 2 files changed, 8 deletions(-)

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 85aa871..cfb8fa3 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -655,12 +655,6 @@ static const BlockDevOps virtio_block_ops = {
     .resize_cb = virtio_blk_resize,
 };
 
-void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk)
-{
-    VirtIOBlock *s = VIRTIO_BLK(dev);
-    memcpy(&(s->blk), blk, sizeof(struct VirtIOBlkConf));
-}
-
 #ifdef CONFIG_VIRTIO_BLK_DATA_PLANE
 /* Disable dataplane thread during live migration since it does not
  * update the dirty memory bitmap yet.
diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index 56c98b1..59cf1f2 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -159,8 +159,6 @@ typedef struct VirtIOBlock {
         DEFINE_PROP_BIT("config-wce", _state, _field.config_wce, 0, true),    \
         DEFINE_PROP_IOTHREAD("x-iothread", _state, _field.iothread)
 
-void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk);
-
 int virtio_blk_handle_scsi_req(VirtIOBlock *blk,
                                VirtQueueElement *elem);
 
-- 
1.9.3

  parent reply	other threads:[~2014-06-18 10:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  9:58 [Qemu-devel] [PATCH v4 0/9] virtio-blk: use alias properties in transport devices Stefan Hajnoczi
2014-06-18  9:58 ` [Qemu-devel] [PATCH v4 1/9] qom: add object_property_add_alias() Stefan Hajnoczi
2014-06-18  9:58 ` [Qemu-devel] [PATCH v4 2/9] virtio-blk: avoid qdev property definition duplication Stefan Hajnoczi
2014-06-18  9:58 ` [Qemu-devel] [PATCH v4 3/9] dataplane: bail out on unsupported transport Stefan Hajnoczi
2014-06-18  9:58 ` [Qemu-devel] [PATCH v4 4/9] virtio-blk: move x-data-plane qdev property to virtio-blk.h Stefan Hajnoczi
2014-06-18  9:58 ` [Qemu-devel] [PATCH v4 5/9] qdev: add qdev_alias_all_properties() Stefan Hajnoczi
2014-06-18  9:58 ` [Qemu-devel] [PATCH v4 6/9] virtio-blk: use aliases instead of duplicate qdev properties Stefan Hajnoczi
2014-06-18  9:58 ` Stefan Hajnoczi [this message]
2014-06-18  9:58 ` [Qemu-devel] [PATCH v4 8/9] virtio: fix virtio-blk child refcount in transports Stefan Hajnoczi
2014-06-25  9:25   ` Peter Crosthwaite
2014-06-18  9:58 ` [Qemu-devel] [PATCH v4 9/9] virtio-blk: move qdev properties into virtio-blk.c Stefan Hajnoczi
2014-06-24 12:22 ` [Qemu-devel] [PATCH v4 0/9] virtio-blk: use alias properties in transport devices Paolo Bonzini
2014-06-30  8:47 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403085516-10340-8-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=afaerber@suse.de \
    --cc=cornelia.huck@de.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).