From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxCfE-0005e4-Jx for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:00:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxCf9-0003n6-IQ for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:00:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxCf9-0003ms-B6 for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:00:15 -0400 From: Stefan Hajnoczi Date: Wed, 18 Jun 2014 17:58:34 +0800 Message-Id: <1403085516-10340-8-git-send-email-stefanha@redhat.com> In-Reply-To: <1403085516-10340-1-git-send-email-stefanha@redhat.com> References: <1403085516-10340-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v4 7/9] virtio-blk: drop virtio_blk_set_conf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, Paolo Bonzini , peter.crosthwaite@xilinx.com, Andreas Faerber , Stefan Hajnoczi This function is no longer used since parent objects now use child aliases to set the VirtIOBlkConf directly. Signed-off-by: Stefan Hajnoczi Reviewed-by: Peter Crosthwaite --- hw/block/virtio-blk.c | 6 ------ include/hw/virtio/virtio-blk.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 85aa871..cfb8fa3 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -655,12 +655,6 @@ static const BlockDevOps virtio_block_ops = { .resize_cb = virtio_blk_resize, }; -void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk) -{ - VirtIOBlock *s = VIRTIO_BLK(dev); - memcpy(&(s->blk), blk, sizeof(struct VirtIOBlkConf)); -} - #ifdef CONFIG_VIRTIO_BLK_DATA_PLANE /* Disable dataplane thread during live migration since it does not * update the dirty memory bitmap yet. diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h index 56c98b1..59cf1f2 100644 --- a/include/hw/virtio/virtio-blk.h +++ b/include/hw/virtio/virtio-blk.h @@ -159,8 +159,6 @@ typedef struct VirtIOBlock { DEFINE_PROP_BIT("config-wce", _state, _field.config_wce, 0, true), \ DEFINE_PROP_IOTHREAD("x-iothread", _state, _field.iothread) -void virtio_blk_set_conf(DeviceState *dev, VirtIOBlkConf *blk); - int virtio_blk_handle_scsi_req(VirtIOBlock *blk, VirtQueueElement *elem); -- 1.9.3