From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxGkp-0000Cw-Nw for qemu-devel@nongnu.org; Wed, 18 Jun 2014 10:22:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxGkk-00086W-06 for qemu-devel@nongnu.org; Wed, 18 Jun 2014 10:22:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxGkj-00085w-Nm for qemu-devel@nongnu.org; Wed, 18 Jun 2014 10:22:17 -0400 Date: Wed, 18 Jun 2014 17:22:43 +0300 From: "Michael S. Tsirkin" Message-ID: <1403101356-32453-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] vhost: block migration if backend does not log memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Antonios Motakis , Nikolay Nikolaev vhost user does not support LOG_ALL feature bit. Generally, we should not try to set this bit without checking that backend can support it first. Detect and block migration. Cc: Antonios Motakis Cc: Nikolay Nikolaev Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/vhost.h | 1 + hw/virtio/vhost.c | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h index 33028ec..d5593d1 100644 --- a/include/hw/virtio/vhost.h +++ b/include/hw/virtio/vhost.h @@ -45,6 +45,7 @@ struct vhost_dev { bool log_enabled; vhost_log_chunk_t *log; unsigned long long log_size; + Error *migration_blocker; bool force; bool memory_changed; hwaddr mem_changed_start_addr; diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 3f4e35f..f63941d 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -856,6 +856,13 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque, .eventfd_del = vhost_eventfd_del, .priority = 10 }; + if (!(hdev->features & (0x1 << VHOST_F_LOG_ALL))) { + error_setg(&hdev->migration_blocker, + "Migration disabled: vhost lacks VHOST_F_LOG_ALL feature."); + migrate_add_blocker(hdev->migration_blocker); + } else { + hdev->migration_blocker = NULL; + } hdev->mem = g_malloc0(offsetof(struct vhost_memory, regions)); hdev->n_mem_sections = 0; hdev->mem_sections = NULL; @@ -884,6 +891,10 @@ void vhost_dev_cleanup(struct vhost_dev *hdev) vhost_virtqueue_cleanup(hdev->vqs + i); } memory_listener_unregister(&hdev->memory_listener); + if (hdev->migration_blocker) { + migrate_del_blocker(hdev->migration_blocker); + error_free(hdev->migration_blocker); + } g_free(hdev->mem); g_free(hdev->mem_sections); hdev->vhost_ops->vhost_backend_cleanup(hdev); -- MST