From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIf0-0000rg-6o for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:24:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxIeu-0001zU-86 for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:24:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxIet-0001zK-WF for qemu-devel@nongnu.org; Wed, 18 Jun 2014 12:24:24 -0400 From: Amos Kong Date: Thu, 19 Jun 2014 00:24:09 +0800 Message-Id: <1403108653-26765-1-git-send-email-akong@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v5 0/4] test virtio-blk hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, arei.gonglei@huawei.com, afaerber@suse.de, pbonzini@redhat.com It's worth to add a hotplug test to qtest, but without cooperation of guest OS, new devices can't be initialized by guest, and hot-unplug doesn't work. However, the new test can cover some part of code of hotplug/unplug. I will write another subtest to test hotplug with pci support. V2: move qmp_exec_hmp_cmd() to libqtest.c excape hmp cmd (stefanha) use qmp_exec_hmp_cmd() in blockdev-test V3: use vp_list to format string, free escaped string V4: free escaped string by g_free() V5: escape cmd string in QMP command (so this patchset depends on http://article.gmane.org/gmane.comp.emulators.qemu/279835) directly use QMP cmd to add/del device and blockdev cleanup as suggested by Andreas Amos Kong (4): qtest: introduce qmp_exec_hmp_cmd() qtest: use qmp_exec_hmp_cmd() in blockdev-test virtio-blk-test.c: change pci_nop() to virtblk_init() virtio-blk-test.c: add hotplug subtest tests/blockdev-test.c | 23 ++------------ tests/libqtest.c | 23 ++++++++++++++ tests/libqtest.h | 9 ++++++ tests/virtio-blk-test.c | 81 ++++++++++++++++++++++++++++++++++++++++++++----- 4 files changed, 108 insertions(+), 28 deletions(-) -- 1.9.3