From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxPKX-00058k-7D for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:31:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxPKR-00029d-3E for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:31:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxPKQ-00029Y-HR for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:31:42 -0400 From: Fam Zheng Date: Thu, 19 Jun 2014 07:31:57 +0800 Message-Id: <1403134317-6817-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH] raw: Fix segfault in raw_create when opts is NULL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Chunyan Liu , Stefan Hajnoczi , Milos Vyletel Reported-by: Milos Vyletel Signed-off-by: Fam Zheng --- block/raw-posix.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index dacf4fb..1f45fd8 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1282,8 +1282,10 @@ static int raw_create(const char *filename, QemuOpts *opts, Error **errp) strstart(filename, "file:", &filename); /* Read out options */ - total_size = - qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0) / BDRV_SECTOR_SIZE; + if (opts) { + total_size = + qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0) / BDRV_SECTOR_SIZE; + } fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0644); -- 2.0.0