From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxPN7-0006YF-TO for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:34:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxPN1-0003M4-U0 for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:34:29 -0400 Received: from mail-qa0-x231.google.com ([2607:f8b0:400d:c00::231]:54055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxPN1-0003Lo-Pp for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:34:23 -0400 Received: by mail-qa0-f49.google.com with SMTP id w8so1316778qac.8 for ; Wed, 18 Jun 2014 16:34:23 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Wed, 18 Jun 2014 16:33:48 -0700 Message-Id: <1403134428-2705-2-git-send-email-rth@twiddle.net> In-Reply-To: <1403134428-2705-1-git-send-email-rth@twiddle.net> References: <1403134428-2705-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL] tcg/optimize: Don't special case TCG_OPF_CALL_CLOBBER List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org With the "old" ldst ops we didn't know the real width of the result of the load, but with the "new" ldst ops we do. Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 16cebbe..34ae3c2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -911,12 +911,11 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, break; } - /* 32-bit ops (non 64-bit ops and non load/store ops) generate - 32-bit results. For the result is zero test below, we can - ignore high bits, but for further optimizations we need to - record that the high bits contain garbage. */ + /* 32-bit ops generate 32-bit results. For the result is zero test + below, we can ignore high bits, but for further optimizations we + need to record that the high bits contain garbage. */ partmask = mask; - if (!(def->flags & (TCG_OPF_CALL_CLOBBER | TCG_OPF_64BIT))) { + if (!(def->flags & TCG_OPF_64BIT)) { mask |= ~(tcg_target_ulong)0xffffffffu; partmask &= 0xffffffffu; affected &= 0xffffffffu; -- 1.9.3