From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47740)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WxYlf-0003qV-Pu
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 05:36:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WxYlZ-0000NL-Lw
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 05:36:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64087)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WxYlZ-0000NF-Dp
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 05:36:21 -0400
Message-ID: <1403170570.22530.5.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 19 Jun 2014 11:36:10 +0200
In-Reply-To: <1403096614.7661.208.camel@pasglop>
References: <1402974463.7661.102.camel@pasglop>
	<1403001900.1614.10.camel@nilsson.home.kraxel.org>
	<1403003721.7661.148.camel@pasglop>
	<1403006267.1614.14.camel@nilsson.home.kraxel.org>
	<1403040734.7661.173.camel@pasglop>
	<1403090315.13406.3.camel@nilsson.home.kraxel.org>
	<1403096614.7661.208.camel@pasglop>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing
	changes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On Mi, 2014-06-18 at 23:03 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2014-06-18 at 13:18 +0200, Gerd Hoffmann wrote:
> > The dispi interface has a versioned id too (VBE_DISPI_IDx) which we
> > could use too.  Which makes sense IMO if we add the register to the
> > bochs dispi registers.
> > 
> > We could also place the register in pci config space, then indicate it
> > exists by either creating it a vendor pci capability or by pci
> > revision.
> 
> I'm not fan of the config space option .. I don't like vendor specific
> stuff in PCI config space. I prefer adding a DISPI VBE register since
> we never compile that out (despite the ifdef's being still around) do
> we ?

Yes, the #ifdefs are a leftover, it is always compiled in.

> I've tried to engage with the Bochs folks on their mailing list to make
> sure they agree in principle at least but have had no reply yet.

If we can get to an agreement here -- perfectly fine.

If not -- then I prefer to play save and not use a vbe register to avoid
ending up with two incompatible bochs interface revisions.  If you don't
like the pci config space option -- the mmio bar has plenty of free
space left ;)

cheers,
  Gerd