From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 2/3] vnc: Drop superfluous conditionals around g_strdup()
Date: Thu, 19 Jun 2014 13:03:48 +0200 [thread overview]
Message-ID: <1403175829-24595-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1403175829-24595-1-git-send-email-kraxel@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/vnc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index d771a2c..6c9d4f3 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3009,10 +3009,7 @@ int vnc_display_password(DisplayState *ds, const char *password)
}
g_free(vs->password);
- vs->password = NULL;
- if (password) {
- vs->password = g_strdup(password);
- }
+ vs->password = g_strdup(password);
return 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2014-06-19 11:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 11:03 [Qemu-devel] [PULL 0/3] vnc: cleanups and fixes Gerd Hoffmann
2014-06-19 11:03 ` [Qemu-devel] [PULL 1/3] vnc: Drop superfluous conditionals around g_free() Gerd Hoffmann
2014-06-19 11:03 ` Gerd Hoffmann [this message]
2014-06-19 11:03 ` [Qemu-devel] [PULL 3/3] vnc: fix screen updates Gerd Hoffmann
2014-08-27 4:39 ` Zhang Haoyu
2014-06-20 16:40 ` [Qemu-devel] [PULL 0/3] vnc: cleanups and fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403175829-24595-3-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).