qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.a@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] hw/pcie: better hotplug/hotunplug support
Date: Thu, 19 Jun 2014 16:52:18 +0300	[thread overview]
Message-ID: <1403185941-19561-1-git-send-email-marcel.a@redhat.com> (raw)

Hotplug triggers both 'present detect change' and
'attention button pressed'.

Hotunplug starts by triggering 'attention button pressed',
then waits for the OS to power off the device and only
then detaches it.

patch 1/3: trivial debug message fix
patch 2/3: enable 'power controller' to receive power events from guests
patch 3/3: the actual hotplug/hotunplug implementation.

Tested with Linux and Windows guests and with an e1000 with "PCIe" capability.
Notes:
    Windows requires devices to be pci express in order to enable
    hotplug functionality, so we need to think about converting
    virtio devices to pci express.
    Linux outputs a "Surprise Removal/Addition" info message because
    we trigger 2 events in the same time, however this warning
    can be disregarded or a kernel patch submitted for our scenario.

Marcel Apfelbaum (3):
  hw/pcie: corrected a debug message
  hw/pcie: implement power controller functionality
  hw/pcie: better hotplug/hotunplug support

 hw/pci/pcie.c              | 37 ++++++++++++++++++++++++++++++-------
 include/hw/pci/pcie_regs.h |  2 ++
 2 files changed, 32 insertions(+), 7 deletions(-)

-- 
1.8.3.1

             reply	other threads:[~2014-06-19 13:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19 13:52 Marcel Apfelbaum [this message]
2014-06-19 13:52 ` [Qemu-devel] [PATCH 1/3] hw/pcie: corrected a debug message Marcel Apfelbaum
2014-06-19 13:52 ` [Qemu-devel] [PATCH 2/3] hw/pcie: implement power controller functionality Marcel Apfelbaum
2014-06-19 14:39   ` Michael S. Tsirkin
2014-06-19 20:56     ` Paolo Bonzini
2014-06-22 10:47     ` Marcel Apfelbaum
2014-06-22 10:52       ` Michael S. Tsirkin
2014-06-22 11:11         ` Michael S. Tsirkin
2014-06-22 11:17           ` Marcel Apfelbaum
2014-06-19 13:52 ` [Qemu-devel] [PATCH 3/3] hw/pcie: better hotplug/hotunplug support Marcel Apfelbaum
2014-06-19 14:43   ` Michael S. Tsirkin
2014-06-22 10:54     ` Marcel Apfelbaum
2014-06-22 11:03       ` Michael S. Tsirkin
2014-06-22 11:11         ` Marcel Apfelbaum
2014-06-22 11:12           ` Michael S. Tsirkin
2014-06-22 11:24             ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403185941-19561-1-git-send-email-marcel.a@redhat.com \
    --to=marcel.a@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).