From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxzBZ-0006xM-F3 for qemu-devel@nongnu.org; Fri, 20 Jun 2014 09:49:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxzBU-0004dt-Gq for qemu-devel@nongnu.org; Fri, 20 Jun 2014 09:48:57 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:47015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxzBU-0004dM-Be for qemu-devel@nongnu.org; Fri, 20 Jun 2014 09:48:52 -0400 From: James Hogan Date: Fri, 20 Jun 2014 14:48:35 +0100 Message-ID: <1403272115-10921-1-git-send-email-james.hogan@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2] mips_malta: Don't boot from flash with KVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , James Hogan , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Aurelien Jarno In KVM mode the flash reset region at 0xbfc00000 isn't executable, which is why the minimal kernel bootloader is loaded and executed from the last 1MB of DRAM instead. Therefore if no kernel is provided on the command line and KVM is enabled, exit with an error since booting from flash will fail. Reported-by: Aurelien Jarno Signed-off-by: James Hogan Reviewed-by: Andreas F=C3=A4rber Cc: Paolo Bonzini --- Changes in v2: - Remove mention of T&E. There is currently no distinction since VZ isn't supported, and technically the limitation isn't T&E specific. (Andreas F=C3=A4rber) --- hw/mips/mips_malta.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index 8bc5392b4223..a54ed65a6b73 100644 --- a/hw/mips/mips_malta.c +++ b/hw/mips/mips_malta.c @@ -1052,6 +1052,12 @@ void mips_malta_init(MachineState *machine) bootloader_run_addr, kernel_entry); } } else { + /* The flash region isn't executable from a KVM guest */ + if (kvm_enabled()) { + error_report("KVM enabled but no -kernel argument was specif= ied. " + "Booting from flash is not supported with KVM."= ); + exit(1); + } /* Load firmware from flash. */ if (!dinfo) { /* Load a BIOS image. */ --=20 1.9.3