* [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16
@ 2014-06-21 19:35 Aurelien Jarno
2014-06-21 20:06 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2014-06-21 19:35 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Aurelien Jarno
The roundAndPackFloat16 function should return a float16 value, not a
float32 one. Fix that.
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
fpu/softfloat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index e00a6fb..3b19736 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -3209,7 +3209,7 @@ static float16 packFloat16(flag zSign, int_fast16_t zExp, uint16_t zSig)
| Binary Floating-Point Arithmetic.
*----------------------------------------------------------------------------*/
-static float32 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
+static float16 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
uint32_t zSig, flag ieee STATUS_PARAM)
{
int maxexp = ieee ? 29 : 30;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16
2014-06-21 19:35 [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16 Aurelien Jarno
@ 2014-06-21 20:06 ` Peter Maydell
2014-06-21 20:29 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2014-06-21 20:06 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: QEMU Developers
On 21 June 2014 20:35, Aurelien Jarno <aurelien@aurel32.net> wrote:
> The roundAndPackFloat16 function should return a float16 value, not a
> float32 one. Fix that.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Agreed, though I don't think it has any effect on the results.
Can we have the usual "ok under softfloat 2a or 2b license"
confirmation, please?
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16
2014-06-21 20:06 ` Peter Maydell
@ 2014-06-21 20:29 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2014-06-21 20:29 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers
On Sat, Jun 21, 2014 at 09:06:21PM +0100, Peter Maydell wrote:
> On 21 June 2014 20:35, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > The roundAndPackFloat16 function should return a float16 value, not a
> > float32 one. Fix that.
> >
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> Agreed, though I don't think it has any effect on the results.
No, it doesn't have any effect on the results, but it produces slightly
less optimized code. The main problem there is that it fails to build
when enforcing type checking, though less and less targets are compiling
when it is enabled.
> Can we have the usual "ok under softfloat 2a or 2b license"
> confirmation, please?
Yes, I am fine to license this patch under softfloat 2a or 2b license.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-21 20:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-21 19:35 [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16 Aurelien Jarno
2014-06-21 20:06 ` Peter Maydell
2014-06-21 20:29 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).