From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wyeyn-0000hY-Qp for qemu-devel@nongnu.org; Sun, 22 Jun 2014 06:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wyeyh-0005LG-Ue for qemu-devel@nongnu.org; Sun, 22 Jun 2014 06:26:33 -0400 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:54623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wyeyh-0005Kx-Oj for qemu-devel@nongnu.org; Sun, 22 Jun 2014 06:26:27 -0400 Received: by mail-wg0-f45.google.com with SMTP id l18so5343080wgh.4 for ; Sun, 22 Jun 2014 03:26:26 -0700 (PDT) Sender: Paul Burton From: Paul Burton Date: Sun, 22 Jun 2014 11:25:41 +0100 Message-Id: <1403432748-4679-10-git-send-email-paul@archlinuxmips.org> In-Reply-To: <1403432748-4679-1-git-send-email-paul@archlinuxmips.org> References: <1403432748-4679-1-git-send-email-paul@archlinuxmips.org> Subject: [Qemu-devel] [PATCH v3 09/16] linux-user: allow NULL tv argument for settimeofday List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio , Paul Burton The tv argument to the settimeofday syscall is allowed to be NULL, if the program only wishes to provide the timezone. QEMU previously returned -EFAULT when tv was NULL. Instead, execute the syscall & provide NULL to the kernel as the target program expected. Signed-off-by: Paul Burton --- Changes in v3: - Fix coding style, checkpatch clean. Changes in v2: - None. --- linux-user/syscall.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 4f01bb7..700cfec 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6353,11 +6353,15 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, break; case TARGET_NR_settimeofday: { - struct timeval tv; + struct timeval tv, *ptv = NULL; struct timezone tz, *ptz = NULL; - if (copy_from_user_timeval(&tv, arg1)) - goto efault; + if (arg1) { + if (copy_from_user_timeval(&tv, arg1)) { + goto efault; + } + ptv = &tv; + } if (arg2) { if (copy_from_user_timezone(&tz, arg2)) { @@ -6366,7 +6370,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, ptz = &tz; } - ret = get_errno(settimeofday(&tv, ptz)); + ret = get_errno(settimeofday(ptv, ptz)); } break; #if defined(TARGET_NR_select) -- 2.0.0