[Qemu-devel] [PATCH] input: fix jumpy mouse cursor with USB mouse emulation

[Qemu-devel] [PATCH] input: fix jumpy mouse cursor with USB mouse emulation

[Christian Burger]

Guest mouse pointer was jumpy, when moving host mouse in the vertical direction (see bug #1327800).

Signed-off-by: Christian Burger <christian@krikkel.de>
---
 hw/input/hid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/input/hid.c b/hw/input/hid.c
index 295bdab..c58847e 100644
--- a/hw/input/hid.c
+++ b/hw/input/hid.c
@@ -124,7 +124,7 @@ static void hid_pointer_event(DeviceState *dev, QemuConsole *src,
         if (evt->rel->axis == INPUT_AXIS_X) {
             e->xdx += evt->rel->value;
         } else if (evt->rel->axis == INPUT_AXIS_Y) {
-            e->ydy -= evt->rel->value;
+            e->ydy += evt->rel->value;
         }
         break;
 
@@ -191,7 +191,7 @@ static void hid_pointer_sync(DeviceState *dev)
         if (hs->kind == HID_MOUSE) {
             prev->xdx += curr->xdx;
             curr->xdx = 0;
-            prev->ydy -= curr->ydy;
+            prev->ydy += curr->ydy;
             curr->ydy = 0;
         } else {
             prev->xdx = curr->xdx;
-- 
1.8.5.5

Re: [Qemu-devel] [PATCH] input: fix jumpy mouse cursor with USB mouse emulation

[Benjamin Herrenschmidt]

On Sat, 2014-06-14 at 20:19 +0100, Christian Burger wrote:
> Guest mouse pointer was jumpy, when moving host mouse in the vertical direction (see bug #1327800).

Ah, I've just done a deep dive into qemu input code to debug that
one as well :-)

It's not just "jumpy", it goes the wrong way around too...

> Signed-off-by: Christian Burger <christian@krikkel.de>

Tested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  hw/input/hid.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/input/hid.c b/hw/input/hid.c
> index 295bdab..c58847e 100644
> --- a/hw/input/hid.c
> +++ b/hw/input/hid.c
> @@ -124,7 +124,7 @@ static void hid_pointer_event(DeviceState *dev, QemuConsole *src,
>          if (evt->rel->axis == INPUT_AXIS_X) {
>              e->xdx += evt->rel->value;
>          } else if (evt->rel->axis == INPUT_AXIS_Y) {
> -            e->ydy -= evt->rel->value;
> +            e->ydy += evt->rel->value;
>          }
>          break;
>  
> @@ -191,7 +191,7 @@ static void hid_pointer_sync(DeviceState *dev)
>          if (hs->kind == HID_MOUSE) {
>              prev->xdx += curr->xdx;
>              curr->xdx = 0;
> -            prev->ydy -= curr->ydy;
> +            prev->ydy += curr->ydy;
>              curr->ydy = 0;
>          } else {
>              prev->xdx = curr->xdx;