From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Liu Yuan <namei.unix@gmail.com>
Subject: [Qemu-devel] [PULL 4/6] sheepdog: fix NULL dereference in sd_create
Date: Mon, 23 Jun 2014 17:31:17 +0800 [thread overview]
Message-ID: <1403515879-14359-5-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1403515879-14359-1-git-send-email-stefanha@redhat.com>
From: Liu Yuan <namei.unix@gmail.com>
Following command
qemu-img create -f qcow2 sheepdog:test 20g
will cause core dump because aio_context is NULL in sd_create. We should
initialize it by qemu_get_aio_context() to avoid NULL dereference.
Cc: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Liu Yuan <namei.unix@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/sheepdog.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 2dcc595..8d9350c 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -1756,6 +1756,7 @@ static int sd_create(const char *filename, QemuOpts *opts,
bdrv_unref(bs);
}
+ s->aio_context = qemu_get_aio_context();
ret = do_sd_create(s, &vid, 0, errp);
if (ret) {
goto out;
--
1.9.3
next prev parent reply other threads:[~2014-06-23 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 9:31 [Qemu-devel] [PULL 0/6] Block patches Stefan Hajnoczi
2014-06-23 9:31 ` [Qemu-devel] [PULL 1/6] block: m25p80: sync_page(): Deindent function body Stefan Hajnoczi
2014-06-23 9:31 ` [Qemu-devel] [PULL 2/6] block: m25p80: Support read only bdrvs Stefan Hajnoczi
2014-06-23 9:31 ` [Qemu-devel] [PULL 3/6] QemuOpts: check NULL opts in qemu_opt_get functions Stefan Hajnoczi
2014-06-23 9:31 ` Stefan Hajnoczi [this message]
2014-06-23 9:31 ` [Qemu-devel] [PULL 5/6] vl: allow other threads to do qemu_system_vmstop_request Stefan Hajnoczi
2014-06-23 9:31 ` [Qemu-devel] [PULL 6/6] block: asynchronously stop the VM on I/O errors Stefan Hajnoczi
2014-06-23 12:18 ` [Qemu-devel] [PULL 0/6] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403515879-14359-5-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=namei.unix@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).