From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz0bX-0002dp-Ix for qemu-devel@nongnu.org; Mon, 23 Jun 2014 05:32:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz0bS-0004fl-H4 for qemu-devel@nongnu.org; Mon, 23 Jun 2014 05:31:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz0bS-0004fb-9R for qemu-devel@nongnu.org; Mon, 23 Jun 2014 05:31:54 -0400 From: Stefan Hajnoczi Date: Mon, 23 Jun 2014 17:31:17 +0800 Message-Id: <1403515879-14359-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1403515879-14359-1-git-send-email-stefanha@redhat.com> References: <1403515879-14359-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 4/6] sheepdog: fix NULL dereference in sd_create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Stefan Hajnoczi , Liu Yuan From: Liu Yuan Following command qemu-img create -f qcow2 sheepdog:test 20g will cause core dump because aio_context is NULL in sd_create. We should initialize it by qemu_get_aio_context() to avoid NULL dereference. Cc: qemu-devel@nongnu.org Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 2dcc595..8d9350c 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -1756,6 +1756,7 @@ static int sd_create(const char *filename, QemuOpts *opts, bdrv_unref(bs); } + s->aio_context = qemu_get_aio_context(); ret = do_sd_create(s, &vid, 0, errp); if (ret) { goto out; -- 1.9.3