qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Fam Zheng <famz@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PULL 15/23] virtio-pci: Report an error when msix vectors init fails
Date: Mon, 23 Jun 2014 18:53:58 +0300	[thread overview]
Message-ID: <1403538745-18622-16-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1403538745-18622-1-git-send-email-mst@redhat.com>

From: Fam Zheng <famz@redhat.com>

Currently vectors silently cleared to 0 if the initialization is failed,
but user should at least have one way to notice this.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/virtio/virtio-pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index ce97514..57e1e61 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -976,6 +976,8 @@ static void virtio_pci_device_plugged(DeviceState *d)
 
     if (proxy->nvectors &&
         msix_init_exclusive_bar(&proxy->pci_dev, proxy->nvectors, 1)) {
+        error_report("unable to init msix vectors to %" PRIu32,
+                     proxy->nvectors);
         proxy->nvectors = 0;
     }
 
-- 
MST

  parent reply	other threads:[~2014-06-23 15:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 15:53 [Qemu-devel] [PULL 00/23] pc,pci,vhost,net fixes, enhancements Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 01/23] vhost: block migration if backend does not log memory Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 02/23] vhost: fix resource leak in error handling Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 03/23] qapi/hmp: use 'backend' instead of 'device' with memory backend Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 04/23] libqemustub: add more stubs for qemu-char Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 05/23] qtest: fix qtest for vhost-user Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 06/23] qtest: fix vhost-user-test unbalanced mutex locks Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 07/23] e1000: emulate auto-negotiation during external link status change Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 08/23] e1000: improve auto-negotiation reporting via mii-tool Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 09/23] e1000: signal guest on successful link auto-negotiation Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 10/23] e1000: move e1000_autoneg_timer() to after set_ics() Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 11/23] e1000: factor out checking for auto-negotiation availability Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 12/23] qapi/string-output-visitor: fix human output Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 13/23] qemu-char: fix qemu_chr_fe_get_msgfd() Michael S. Tsirkin
2014-06-23 15:53 ` [Qemu-devel] [PULL 14/23] qemu-char: avoid leaking unused fds in tcp_get_msgfds() Michael S. Tsirkin
2014-06-23 15:53 ` Michael S. Tsirkin [this message]
2014-06-23 15:54 ` [Qemu-devel] [PULL 16/23] q35: Use PC_Q35_COMPAT_1_4 on pc-q35-1.4 compat_props Michael S. Tsirkin
2014-06-23 15:54 ` [Qemu-devel] [PULL 17/23] hw/pcie: correct debug message Michael S. Tsirkin
2014-06-23 15:54 ` [Qemu-devel] [PULL 18/23] hw/pcie: implement power controller functionality Michael S. Tsirkin
2014-06-23 15:54 ` [Qemu-devel] [PULL 19/23] hw/pcie: better hotplug/hotunplug support Michael S. Tsirkin
2014-06-23 15:54 ` [Qemu-devel] [PULL 20/23] pcie: coding style tweak Michael S. Tsirkin
2014-06-23 15:54 ` [Qemu-devel] [PULL 21/23] xen-hvm: Fix xen_hvm_init() to adjust pc memory layout Michael S. Tsirkin
2014-06-23 15:54 ` [Qemu-devel] [PULL 22/23] pc & q35: Add new machine opt max-ram-below-4g Michael S. Tsirkin
2014-06-23 15:54 ` [Qemu-devel] [PULL 23/23] xen-hvm: Handle " Michael S. Tsirkin
2014-06-24 11:21 ` [Qemu-devel] [PULL 00/23] pc,pci,vhost,net fixes, enhancements Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403538745-18622-16-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).