From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz6Yx-0004fC-IT for qemu-devel@nongnu.org; Mon, 23 Jun 2014 11:53:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wz6Yp-0001px-Hj for qemu-devel@nongnu.org; Mon, 23 Jun 2014 11:53:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wz6Yp-0001pi-9v for qemu-devel@nongnu.org; Mon, 23 Jun 2014 11:53:35 -0400 Date: Mon, 23 Jun 2014 18:53:58 +0300 From: "Michael S. Tsirkin" Message-ID: <1403538745-18622-16-git-send-email-mst@redhat.com> References: <1403538745-18622-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403538745-18622-1-git-send-email-mst@redhat.com> Subject: [Qemu-devel] [PULL 15/23] virtio-pci: Report an error when msix vectors init fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Fam Zheng , Anthony Liguori From: Fam Zheng Currently vectors silently cleared to 0 if the initialization is failed, but user should at least have one way to notice this. Signed-off-by: Fam Zheng Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index ce97514..57e1e61 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -976,6 +976,8 @@ static void virtio_pci_device_plugged(DeviceState *d) if (proxy->nvectors && msix_init_exclusive_bar(&proxy->pci_dev, proxy->nvectors, 1)) { + error_report("unable to init msix vectors to %" PRIu32, + proxy->nvectors); proxy->nvectors = 0; } -- MST