From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzDOy-0006zK-Q5 for qemu-devel@nongnu.org; Mon, 23 Jun 2014 19:11:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzDOt-0003Of-QF for qemu-devel@nongnu.org; Mon, 23 Jun 2014 19:11:52 -0400 Received: from gate.crashing.org ([63.228.1.57]:40445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzDOt-0003OT-8n for qemu-devel@nongnu.org; Mon, 23 Jun 2014 19:11:47 -0400 From: Benjamin Herrenschmidt Date: Tue, 24 Jun 2014 09:11:02 +1000 Message-Id: <1403565068-15229-9-git-send-email-benh@kernel.crashing.org> In-Reply-To: <1403565068-15229-1-git-send-email-benh@kernel.crashing.org> References: <1403565068-15229-1-git-send-email-benh@kernel.crashing.org> Subject: [Qemu-devel] [RFC 08/14] vga: Simplify vga_draw_blank() a bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann The test for surface_bits_per_pixel() isn't necessary anymore, the 8bpp case never happens. Signed-off-by: Benjamin Herrenschmidt --- hw/display/vga.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/display/vga.c b/hw/display/vga.c index 70405e6..3b2cca5 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1639,7 +1639,7 @@ static void vga_draw_graphic(VGACommonState *s, int full_update) static void vga_draw_blank(VGACommonState *s, int full_update) { DisplaySurface *surface = qemu_console_surface(s->con); - int i, w, val; + int i, w; uint8_t *d; if (!full_update) @@ -1647,15 +1647,10 @@ static void vga_draw_blank(VGACommonState *s, int full_update) if (s->last_scr_width <= 0 || s->last_scr_height <= 0) return; - if (surface_bits_per_pixel(surface) == 8) { - val = rgb_to_pixel32(0, 0, 0); - } else { - val = 0; - } w = s->last_scr_width * surface_bytes_per_pixel(surface); d = surface_data(surface); for(i = 0; i < s->last_scr_height; i++) { - memset(d, val, w); + memset(d, 0, w); d += surface_stride(surface); } dpy_gfx_update(s->con, 0, 0, -- 1.9.1