From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58244)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1WzDv0-0005ta-2E
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 19:45:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1WzDuv-0007aX-4W
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 19:44:58 -0400
Received: from gate.crashing.org ([63.228.1.57]:50144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1WzDuu-0007aT-Ml
	for qemu-devel@nongnu.org; Mon, 23 Jun 2014 19:44:53 -0400
Message-ID: <1403567086.4587.139.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Tue, 24 Jun 2014 09:44:46 +1000
In-Reply-To: <CAFEAcA8Ghs2gw33bzzDSvaeh8_ySu=sGdJJop1LroqY5S7RBLQ@mail.gmail.com>
References: <1403565068-15229-1-git-send-email-benh@kernel.crashing.org>
	<1403565068-15229-12-git-send-email-benh@kernel.crashing.org>
	<CAFEAcA8Ghs2gw33bzzDSvaeh8_ySu=sGdJJop1LroqY5S7RBLQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 11/14] vga: Make fb endian a common state
 variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On Tue, 2014-06-24 at 00:24 +0100, Peter Maydell wrote:
> On 24 June 2014 00:11, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > And initialize it based on target endian
> > @@ -155,6 +155,7 @@ typedef struct VGACommonState {
> >      const GraphicHwOps *hw_ops;
> >      bool full_update_text;
> >      bool full_update_gfx;
> > +    bool big_endian_fb;
> 
> Don't we need to migrate this new state somehow?

Only when it can change, which is done in patch 13

This patch (11) just moves it around to the state but its value is still
fixed at this point in the series.

Cheers,
Ben.