* [Qemu-devel] [PATCH] numa: fix comment
@ 2014-06-24 4:45 Michael S. Tsirkin
2014-06-24 5:33 ` Hu Tao
0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2014-06-24 4:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Hu Tao, Eduardo Habkost, Wanlong Gao, Paolo Bonzini
Fix up English in comments:
s/the each/each/
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
numa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/numa.c b/numa.c
index e471afe..47049a5 100644
--- a/numa.c
+++ b/numa.c
@@ -172,7 +172,7 @@ void set_numa_nodes(void)
if (i == nb_numa_nodes) {
uint64_t usedmem = 0;
- /* On Linux, the each node's border has to be 8MB aligned,
+ /* On Linux, each node's border has to be 8MB aligned,
* the final node gets the rest.
*/
for (i = 0; i < nb_numa_nodes - 1; i++) {
--
MST
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] numa: fix comment
2014-06-24 4:45 [Qemu-devel] [PATCH] numa: fix comment Michael S. Tsirkin
@ 2014-06-24 5:33 ` Hu Tao
2014-06-24 5:51 ` Michael S. Tsirkin
0 siblings, 1 reply; 5+ messages in thread
From: Hu Tao @ 2014-06-24 5:33 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Paolo Bonzini, qemu-devel, Wanlong Gao, Eduardo Habkost
On Tue, Jun 24, 2014 at 07:45:15AM +0300, Michael S. Tsirkin wrote:
> Fix up English in comments:
> s/the each/each/
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> numa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/numa.c b/numa.c
> index e471afe..47049a5 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -172,7 +172,7 @@ void set_numa_nodes(void)
> if (i == nb_numa_nodes) {
> uint64_t usedmem = 0;
>
> - /* On Linux, the each node's border has to be 8MB aligned,
> + /* On Linux, each node's border has to be 8MB aligned,
> * the final node gets the rest.
> */
> for (i = 0; i < nb_numa_nodes - 1; i++) {
> --
> MST
There is another one in the same function that can be fixed togehter:
/* If no memory size if given for any node
s/if/is/
Hu
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] numa: fix comment
@ 2014-06-24 5:51 Michael S. Tsirkin
2014-06-24 6:05 ` Igor Mammedov
0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2014-06-24 5:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Hu Tao, Eduardo Habkost, Wanlong Gao, Paolo Bonzini
s/if given for/is given for/;
Reported-by: Hu Tao <hutao@cn.fujitsu.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
numa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/numa.c b/numa.c
index 47049a5..6c2eae7 100644
--- a/numa.c
+++ b/numa.c
@@ -161,7 +161,7 @@ void set_numa_nodes(void)
nb_numa_nodes = MAX_NODES;
}
- /* If no memory size if given for any node, assume the default case
+ /* If no memory size is given for any node, assume the default case
* and distribute the available memory equally across all nodes
*/
for (i = 0; i < nb_numa_nodes; i++) {
--
MST
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] numa: fix comment
2014-06-24 5:33 ` Hu Tao
@ 2014-06-24 5:51 ` Michael S. Tsirkin
0 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2014-06-24 5:51 UTC (permalink / raw)
To: Hu Tao; +Cc: Paolo Bonzini, qemu-devel, Wanlong Gao, Eduardo Habkost
On Tue, Jun 24, 2014 at 01:33:35PM +0800, Hu Tao wrote:
> On Tue, Jun 24, 2014 at 07:45:15AM +0300, Michael S. Tsirkin wrote:
> > Fix up English in comments:
> > s/the each/each/
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > numa.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/numa.c b/numa.c
> > index e471afe..47049a5 100644
> > --- a/numa.c
> > +++ b/numa.c
> > @@ -172,7 +172,7 @@ void set_numa_nodes(void)
> > if (i == nb_numa_nodes) {
> > uint64_t usedmem = 0;
> >
> > - /* On Linux, the each node's border has to be 8MB aligned,
> > + /* On Linux, each node's border has to be 8MB aligned,
> > * the final node gets the rest.
> > */
> > for (i = 0; i < nb_numa_nodes - 1; i++) {
> > --
> > MST
>
> There is another one in the same function that can be fixed togehter:
>
> /* If no memory size if given for any node
>
> s/if/is/
>
> Hu
Fixed, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] numa: fix comment
2014-06-24 5:51 Michael S. Tsirkin
@ 2014-06-24 6:05 ` Igor Mammedov
0 siblings, 0 replies; 5+ messages in thread
From: Igor Mammedov @ 2014-06-24 6:05 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Hu Tao, Paolo Bonzini, qemu-devel, Wanlong Gao, Eduardo Habkost
On Tue, 24 Jun 2014 08:51:23 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> s/if given for/is given for/;
>
> Reported-by: Hu Tao <hutao@cn.fujitsu.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> numa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/numa.c b/numa.c
> index 47049a5..6c2eae7 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -161,7 +161,7 @@ void set_numa_nodes(void)
> nb_numa_nodes = MAX_NODES;
> }
>
> - /* If no memory size if given for any node, assume the default case
> + /* If no memory size is given for any node, assume the default case
> * and distribute the available memory equally across all nodes
> */
> for (i = 0; i < nb_numa_nodes; i++) {
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-24 6:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-24 4:45 [Qemu-devel] [PATCH] numa: fix comment Michael S. Tsirkin
2014-06-24 5:33 ` Hu Tao
2014-06-24 5:51 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2014-06-24 5:51 Michael S. Tsirkin
2014-06-24 6:05 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).