From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzMUH-0002C0-6k for qemu-devel@nongnu.org; Tue, 24 Jun 2014 04:54:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzMUB-0002cw-Dc for qemu-devel@nongnu.org; Tue, 24 Jun 2014 04:53:57 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:46320 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzMUB-0002cf-2p for qemu-devel@nongnu.org; Tue, 24 Jun 2014 04:53:51 -0400 From: Peter Lieven Date: Tue, 24 Jun 2014 10:52:51 +0200 Message-Id: <1403599971-9232-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCHv2] block/nfs: add knob to set readahead List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, Peter Lieven , ronniesahlberg@gmail.com, pbonzini@redhat.com upcoming libnfs will feature internal readahead support. Add a knob to pass the optional readahead value as a URL parameter. This patch fixes also the incorrect usage of strncmp and atoi. Signed-off-by: Peter Lieven --- v1->v2: use strtol instead of atoi [Eric] block/nfs.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/block/nfs.c b/block/nfs.c index ec43201..9783483 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -309,12 +309,16 @@ static int64_t nfs_client_open(NFSClient *client, const char *filename, qp->p[i].name); goto fail; } - if (!strncmp(qp->p[i].name, "uid", 3)) { - nfs_set_uid(client->context, atoi(qp->p[i].value)); - } else if (!strncmp(qp->p[i].name, "gid", 3)) { - nfs_set_gid(client->context, atoi(qp->p[i].value)); - } else if (!strncmp(qp->p[i].name, "tcp-syncnt", 10)) { - nfs_set_tcp_syncnt(client->context, atoi(qp->p[i].value)); + if (!strcmp(qp->p[i].name, "uid")) { + nfs_set_uid(client->context, strtol(qp->p[i].value, NULL, 0)); + } else if (!strcmp(qp->p[i].name, "gid")) { + nfs_set_gid(client->context, strtol(qp->p[i].value, NULL, 0)); + } else if (!strcmp(qp->p[i].name, "tcp-syncnt")) { + nfs_set_tcp_syncnt(client->context, strtol(qp->p[i].value, NULL, 0)); +#ifdef LIBNFS_FEATURE_READAHEAD + } else if (!strcmp(qp->p[i].name, "readahead")) { + nfs_set_readahead(client->context, strtol(qp->p[i].value, NULL, 0)); +#endif } else { error_setg(errp, "Unknown NFS parameter name: %s", qp->p[i].name); -- 1.7.9.5