From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Subject: [Qemu-devel] [PATCH for 2.1 12/14] memory: MemoryRegion: Add may-overlap and priority props
Date: Wed, 25 Jun 2014 14:25:56 +0200 [thread overview]
Message-ID: <1403699158-4344-13-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1403699158-4344-1-git-send-email-pbonzini@redhat.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
QOM propertyify the .may-overlap and .priority fields. The setters
will re-add the memory as a subregion if needed (i.e. the values change
when the memory region is already contained).
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
[Remove setters. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
include/exec/memory.h | 2 +-
memory.c | 24 ++++++++++++++++++++++++
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 0c7e825..e2c8e3e 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -157,7 +157,7 @@ struct MemoryRegion {
bool flush_coalesced_mmio;
MemoryRegion *alias;
hwaddr alias_offset;
- int priority;
+ int32_t priority;
bool may_overlap;
QTAILQ_HEAD(subregions, MemoryRegion) subregions;
QTAILQ_ENTRY(MemoryRegion) subregions_link;
diff --git a/memory.c b/memory.c
index 04dc933..834959b 100644
--- a/memory.c
+++ b/memory.c
@@ -955,6 +955,22 @@ static Object *memory_region_resolve_container(Object *obj, void *opaque,
return OBJECT(mr->container);
}
+static void memory_region_get_priority(Object *obj, Visitor *v, void *opaque,
+ const char *name, Error **errp)
+{
+ MemoryRegion *mr = MEMORY_REGION(obj);
+ int32_t value = mr->priority;
+
+ visit_type_int32(v, &value, name, errp);
+}
+
+static bool memory_region_get_may_overlap(Object *obj, Error **errp)
+{
+ MemoryRegion *mr = MEMORY_REGION(obj);
+
+ return mr->may_overlap;
+}
+
static void memory_region_initfn(Object *obj)
{
MemoryRegion *mr = MEMORY_REGION(obj);
@@ -978,6 +994,14 @@ static void memory_region_initfn(Object *obj)
memory_region_get_addr,
NULL, /* memory_region_set_addr */
NULL, NULL, &error_abort);
+ object_property_add(OBJECT(mr), "priority", "uint32",
+ memory_region_get_priority,
+ NULL, /* memory_region_set_priority */
+ NULL, NULL, &error_abort);
+ object_property_add_bool(OBJECT(mr), "may-overlap",
+ memory_region_get_may_overlap,
+ NULL, /* memory_region_set_may_overlap */
+ &error_abort);
}
static uint64_t unassigned_mem_read(void *opaque, hwaddr addr,
--
1.8.3.1
next prev parent reply other threads:[~2014-06-25 12:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 12:25 [Qemu-devel] [PATCH for 2.1 00/14] My pending qom and memory QOMification patches Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 01/14] qom: add object_property_add_alias() Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 02/14] qom: add a generic mechanism to resolve paths Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 03/14] qom: allow creating an alias of a child<> property Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 04/14] mc146818rtc: add "rtc-time" link to "/machine/rtc" Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 05/14] qom: object: remove parent pointer when unparenting Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 06/14] qom: object: Ignore refs/unrefs of NULL Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 07/14] libqtest: escape strings in QMP commands, fix leak Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 08/14] memory: MemoryRegion: use /machine as default owner Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 09/14] memory: MemoryRegion: QOMify Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 10/14] memory: MemoryRegion: replace owner field with QOM parent Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 11/14] memory: MemoryRegion: Add container and addr props Paolo Bonzini
2014-06-25 12:25 ` Paolo Bonzini [this message]
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 13/14] memory: MemoryRegion: Add size property Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 14/14] memory: do not give a name to the internal exec.c regions Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403699158-4344-13-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).