qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Subject: [Qemu-devel] [PATCH for 2.1 04/14] mc146818rtc: add "rtc-time" link to "/machine/rtc"
Date: Wed, 25 Jun 2014 14:25:48 +0200	[thread overview]
Message-ID: <1403699158-4344-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1403699158-4344-1-git-send-email-pbonzini@redhat.com>

From: Marcelo Tosatti <mtosatti@redhat.com>

Add a link to rtc under /machine providing a stable
location for management apps to query the value of the
time.  The link should be added by any object that sends
RTC_TIME_CHANGE events.

{"execute":"qom-get","arguments":{"path":"/machine","property":"rtc-date"} }

Suggested by Paolo Bonzini and Andreas Faerber.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/timer/mc146818rtc.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 05002bf..81eb517 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -893,6 +893,9 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
 
     object_property_add(OBJECT(s), "date", "struct tm",
                         rtc_get_date, NULL, NULL, s, NULL);
+
+    object_property_add_alias(qdev_get_machine(), "rtc-time",
+                              OBJECT(s), "date", NULL);
 }
 
 ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
@@ -932,11 +935,17 @@ static void rtc_class_initfn(ObjectClass *klass, void *data)
     dc->cannot_instantiate_with_device_add_yet = true;
 }
 
+static void rtc_finalize(Object *obj)
+{
+    object_property_del(qdev_get_machine(), "rtc", NULL);
+}
+
 static const TypeInfo mc146818rtc_info = {
     .name          = TYPE_MC146818_RTC,
     .parent        = TYPE_ISA_DEVICE,
     .instance_size = sizeof(RTCState),
     .class_init    = rtc_class_initfn,
+    .instance_finalize = rtc_finalize,
 };
 
 static void mc146818rtc_register_types(void)
-- 
1.8.3.1

  parent reply	other threads:[~2014-06-25 12:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 12:25 [Qemu-devel] [PATCH for 2.1 00/14] My pending qom and memory QOMification patches Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 01/14] qom: add object_property_add_alias() Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 02/14] qom: add a generic mechanism to resolve paths Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 03/14] qom: allow creating an alias of a child<> property Paolo Bonzini
2014-06-25 12:25 ` Paolo Bonzini [this message]
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 05/14] qom: object: remove parent pointer when unparenting Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 06/14] qom: object: Ignore refs/unrefs of NULL Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 07/14] libqtest: escape strings in QMP commands, fix leak Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 08/14] memory: MemoryRegion: use /machine as default owner Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 09/14] memory: MemoryRegion: QOMify Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 10/14] memory: MemoryRegion: replace owner field with QOM parent Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 11/14] memory: MemoryRegion: Add container and addr props Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 12/14] memory: MemoryRegion: Add may-overlap and priority props Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 13/14] memory: MemoryRegion: Add size property Paolo Bonzini
2014-06-25 12:25 ` [Qemu-devel] [PATCH for 2.1 14/14] memory: do not give a name to the internal exec.c regions Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403699158-4344-5-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).