From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzoJ9-0003do-LF for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:36:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzoJ2-0002Sa-4K for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:36:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzoJ1-0002SO-Tp for qemu-devel@nongnu.org; Wed, 25 Jun 2014 10:36:12 -0400 From: Kevin Wolf Date: Wed, 25 Jun 2014 16:35:50 +0200 Message-Id: <1403706959-6979-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, benoit.canet@irqsave.net, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com This is the first part of an attempt for disentangling bdrv_open(). At th= e end of this series, bdrv_open() code is somewhat easier to read, but the real changes (including some bug fixes and changes of behaviour) haven't happe= ned yet. Just sending out the first part now to get this merged early and avoid conflicts. v2: - Rebased on current git master - Patch 1: Removed redundant if condition [Beno=C3=AEt] Replaced redundant error check with assertion [Eric] - Patch 2: Fixed leak in error path [Beno=C3=AEt] Kevin Wolf (9): block: Create bdrv_fill_options() block: Move bdrv_fill_options() call to bdrv_open() block: Move json: parsing to bdrv_fill_options() block: Always pass driver name through options QDict block: Use common driver selection code for bdrv_open_file() block: Inline bdrv_file_open() block: Remove second bdrv_open() recursion block: Catch backing files assigned to non-COW drivers block: Remove a special case for protocols block.c | 280 ++++++++++++++++++++++-----------------= ------ block/cow.c | 1 + block/qcow.c | 1 + block/qcow2.c | 1 + block/qed.c | 1 + block/vmdk.c | 1 + include/block/block_int.h | 3 + tests/qemu-iotests/051 | 6 + tests/qemu-iotests/051.out | 14 ++- 9 files changed, 164 insertions(+), 144 deletions(-) --=20 1.8.3.1