qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Benoît Canet" <benoit@irqsave.net>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/2] block: Fix unset "filename" for certain drivers
Date: Thu, 26 Jun 2014 21:09:20 +0200	[thread overview]
Message-ID: <1403809762-4858-1-git-send-email-mreitz@redhat.com> (raw)

For some protocol block drivers, the "filename" attribute in their BDSs
is unset due to bdrv_file_open() removing it from the options QDict
before bdrv_open_common() is able to copy it into the BDS. Fix this by
not removing it until until bdrv_open_common() has indeed copied it.


v2:
 - Patch 1: Only remove "filename" from the QDict if it has been parsed
   before; this prevents removal of the entry if it is given for some
   driver which supports neither parsing not filenames at all (such as
   all non-protocol drivers) which would then break test 051 [Stefan]
 - Patch 2: Fixed the headline of the test output


git-backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/2:[0014] [FC] 'block: Do not prematurely remove "filename"'
002/2:[0002] [FC] 'iotests: Add test for set "filename" for NBD'


Max Reitz (2):
  block: Do not prematurely remove "filename"
  iotests: Add test for set "filename" for NBD

 block.c                    | 24 +++++++++++-----
 tests/qemu-iotests/097     | 72 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/097.out | 13 +++++++++
 tests/qemu-iotests/group   |  1 +
 4 files changed, 103 insertions(+), 7 deletions(-)
 create mode 100755 tests/qemu-iotests/097
 create mode 100644 tests/qemu-iotests/097.out

-- 
2.0.0

             reply	other threads:[~2014-06-26 19:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26 19:09 Max Reitz [this message]
2014-06-26 19:09 ` [Qemu-devel] [PATCH v2 1/2] block: Do not prematurely remove "filename" Max Reitz
2014-06-26 19:46   ` Eric Blake
2014-06-26 20:01     ` Max Reitz
2014-06-26 20:06       ` Max Reitz
2014-06-26 19:09 ` [Qemu-devel] [PATCH v2 2/2] iotests: Add test for set "filename" for NBD Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403809762-4858-1-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).