From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Qjo-00059M-16 for qemu-devel@nongnu.org; Fri, 27 Jun 2014 03:38:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X0Qjf-0000es-T2 for qemu-devel@nongnu.org; Fri, 27 Jun 2014 03:38:23 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:53735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X0Qjf-0000bW-3S for qemu-devel@nongnu.org; Fri, 27 Jun 2014 03:38:15 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 27 Jun 2014 13:08:11 +0530 From: Nikunj A Dadhania Date: Fri, 27 Jun 2014 13:07:55 +0530 Message-Id: <1403854675-28778-1-git-send-email-nikunj@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v4] ppc: spapr-rtas - implement os-term rtas call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, agraf@suse.de Cc: aik@ozlabs.ru, Benjamin Herrenschmidt , qemu-ppc@nongnu.org, Anton Blanchard , nikunj@linux.vnet.ibm.com PAPR compliant guest calls this in absence of kdump. This finally reaches the guest and can be handled according to the policies set by higher level tools(like taking dump) for further analysis by tools like crash. Linux kernel calls this only when the extended version of os,term is implemented to make sure that a return to the linux kernel is gauranteed. CC: Benjamin Herrenschmidt CC: Anton Blanchard CC: Alexander Graf Signed-off-by: Nikunj A Dadhania --- v2: rebase to ppcnext v3: Do not stop the VM, and update comments v4: update spapr_register_rtas and qapi_event changes --- hw/ppc/spapr_rtas.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 9ba1ba6..b11de41 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -277,6 +277,38 @@ static void rtas_ibm_set_system_parameter(PowerPCCPU *cpu, rtas_st(rets, 0, ret); } +static void rtas_ibm_os_term(PowerPCCPU *cpu, + sPAPREnvironment *spapr, + uint32_t token, uint32_t nargs, + target_ulong args, + uint32_t nret, target_ulong rets) +{ + target_ulong ret = 0; + + qapi_event_send_guest_panicked(GUEST_PANIC_ACTION_PAUSE, &error_abort); + + rtas_st(rets, 0, ret); +} + +/* + * According to PAPR, rtas ibm,os-term, does not gaurantee a return + * back to the guest cpu. + * + * While an additional ibm,extended-os-term property indicates that + * rtas call return will always occur. Below function implements a + * place holder for the same. + */ +static void rtas_ibm_ext_os_term(PowerPCCPU *cpu, + sPAPREnvironment *spapr, + uint32_t token, uint32_t nargs, + target_ulong args, + uint32_t nret, target_ulong rets) +{ + target_ulong ret = RTAS_OUT_NOT_SUPPORTED; + + rtas_st(rets, 0, ret); +} + static struct rtas_call { const char *name; spapr_rtas_fn fn; @@ -404,6 +436,10 @@ static void core_rtas_register_types(void) spapr_rtas_register(RTAS_IBM_SET_SYSTEM_PARAMETER, "ibm,set-system-parameter", rtas_ibm_set_system_parameter); + spapr_rtas_register(RTAS_IBM_OS_TERM, "ibm,os-term", + rtas_ibm_os_term); + spapr_rtas_register(RTAS_IBM_EXTENDED_OS_TERM, "ibm,extended-os-term", + rtas_ibm_ext_os_term); } type_init(core_rtas_register_types) -- 1.8.3.1