qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, wenchaoqemu@gmail.com, lcapitulino@redhat.com,
	stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 2.1 1/2] blockjob: Fix recent BLOCK_JOB_READY regression
Date: Fri, 27 Jun 2014 15:47:21 +0200	[thread overview]
Message-ID: <1403876842-15926-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1403876842-15926-1-git-send-email-armbru@redhat.com>

Commit bcada37 dropped the (undocumented) members type, len, offset,
speed, breaking tests/qemu-iotests/040 and 041.

Restore them.  This fixes 040, and partially fixes 041.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 blockjob.c           | 6 +++++-
 qapi/block-core.json | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/blockjob.c b/blockjob.c
index 4da86cd..37a8f1f 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -256,7 +256,11 @@ void block_job_event_completed(BlockJob *job, const char *msg)
 
 void block_job_event_ready(BlockJob *job)
 {
-    qapi_event_send_block_job_ready(bdrv_get_device_name(job->bs), &error_abort);
+    qapi_event_send_block_job_ready(job->driver->job_type,
+                                    bdrv_get_device_name(job->bs),
+                                    job->len,
+                                    job->offset,
+                                    job->speed, &error_abort);
 }
 
 BlockErrorAction block_job_error_action(BlockJob *job, BlockDriverState *bs,
diff --git a/qapi/block-core.json b/qapi/block-core.json
index af6b436..8f42f24 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1559,4 +1559,8 @@
 # Since: 1.3
 ##
 { 'event': 'BLOCK_JOB_READY',
-  'data': { 'device': 'str' } }
+  'data': { 'type'  : 'BlockJobType',
+            'device': 'str',
+            'len'   : 'int',
+            'offset': 'int',
+            'speed' : 'int' } }
-- 
1.9.3

  reply	other threads:[~2014-06-27 13:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 13:47 [Qemu-devel] [PATCH 2.1 0/2] Fix two recent event regressions Markus Armbruster
2014-06-27 13:47 ` Markus Armbruster [this message]
2014-06-27 16:28   ` [Qemu-devel] [PATCH 2.1 1/2] blockjob: Fix recent BLOCK_JOB_READY regression Kevin Wolf
2014-06-27 16:42     ` Luiz Capitulino
2014-06-27 16:55     ` Markus Armbruster
2014-06-27 13:47 ` [Qemu-devel] [PATCH 2.1 2/2] blockjob: Fix recent BLOCK_JOB_ERROR regression Markus Armbruster
2014-06-27 16:31   ` Kevin Wolf
2014-06-27 16:20 ` [Qemu-devel] [PATCH 2.1 0/2] Fix two recent event regressions Benoît Canet
2014-06-27 16:55 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403876842-15926-2-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wenchaoqemu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).